-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[various] Update READMEs to reflect current OS support #10470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[various] Update READMEs to reflect current OS support #10470
Conversation
|
Version override: the gradle changes are a no-op, so don't need release. We could version and release the README changes (and normally would), but I don't think there's much value in releasing just for that since nothing is actually changing for clients, it's just making things more consistent. |
| @@ -1,6 +1,9 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a mistake; the previous release already made the requirement 3.35. (Probably when I updated the whole repo the example app was updated, and so the package was caught in the CHANGELOG mass-update dragnet.)
| @@ -1,6 +1,9 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same; it was already 3.35.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a series of updates across various packages to align documentation and build configurations with the currently supported OS versions. The changes primarily involve updating README.md files to reflect new minimum supported versions for Android, iOS, and macOS, and increasing the Android minSdkVersion from 21 to 24 in several build.gradle files. Corresponding CHANGELOG.md files have also been updated. The changes are consistent and well-executed, improving the accuracy of the support information for developers.
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Some changelog tests complaining)
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was fast, thank you @stuartmorgan-g!
| * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8. | ||
| * Updates README to reflect currently supported OS versions for the latest | ||
| versions of the endorsed platform implementations. | ||
| * Applications built with older versions of Flutter will continue to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's extra leading whitespace for this bullet for all CHANGELOGs
| * Applications built with older versions of Flutter will continue to | |
| * Applications built with older versions of Flutter will continue to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a nested list item :)
|
CHANGELOG override: The packages that are changed without changelog entries are the ones where the only change is |
minSdkVersionof 21 to 24.Fixes flutter/flutter#178757
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3