This repository was archived by the owner on Apr 29, 2022. It is now read-only.
Use New DlPathEffect Object #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Converting this to a draft till the linked engine patch is reviewed. Thanks. |
JsouLiang
force-pushed
the
Use-New-DlPathEffect-Object
branch
4 times, most recently
from
a70333d to
0a9dfe6
Compare
JsouLiang
force-pushed
the
Use-New-DlPathEffect-Object
branch
from
0a9dfe6 to
6b8c78d
Compare
1 task
chinmaygarde
approved these changes
Apr 21, 2022
JsouLiang
force-pushed
the
Use-New-DlPathEffect-Object
branch
from
6b8c78d to
ff1119d
Compare
Contributor
Author
|
cc @chinmaygarde , why the |
Contributor
|
The CI yaml check can be ignored for this repo. It's something that's getting added automatically but isn't set up for this repo and likely never will be (we'll be moving the contents to flutter/engine before much longer anyway). |
flar
added a commit
that referenced
this pull request
Apr 22, 2022
JsouLiang
added a commit
to JsouLiang/impeller
that referenced
this pull request
Apr 23, 2022
This reverts commit 380e45d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will unblock flutter/engine#32159
cc @flar @chinmaygarde