-
Notifications
You must be signed in to change notification settings - Fork 29.8k
update to the latest null safe packages #66384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
It looks like something else is still pinning old versions (see failures here https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8868420942172530608/+/steps/run_test.dart_for_tool_tests_shard_and_subshard_commands/0/stdout):
|
|
This pull request is not suitable for automatic merging in its current state.
|
|
When I cloned your repo and this branch and tried and do I searched, it turns out that I've reset a couple of times, and sometimes running Do you get a similar problem locally? |
|
@gspencergoog no I am not seeing that issue locally |
|
The internal google failure looks like a flake or unrelated breakage |
Description
Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.
Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.
Tests
No tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.