Skip to content

Conversation

@jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Sep 22, 2020

Description

Updates all null safe dependencies to versions that allow 2.10 stable and 2.11 dev releases.

Also updates flutter_goldens and flutter_goldens_client to allow 2.11 dev.

Tests

No tests

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 22, 2020
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakemac53
Copy link
Contributor Author

jakemac53 commented Sep 22, 2020

It looks like something else is still pinning old versions (see failures here https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8868420942172530608/+/steps/run_test.dart_for_tool_tests_shard_and_subshard_commands/0/stdout):

Because test >=1.16.0-nullsafety <1.16.0-nullsafety.5 depends on test_api 0.2.19-nullsafety and every version of flutter_driver from sdk depends on test_api 0.2.19-nullsafety.2, test >=1.16.0-nullsafety <1.16.0-nullsafety.5 is incompatible with flutter_driver from sdk.
So, because flutter_project depends on both flutter_driver any from sdk and test 1.16.0-nullsafety.4, version solving failed.

I can't find it so help would be appreciated for those who have knowledge here. Thanks @jonahwilliams for helping me offline to find it!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog
Copy link
Contributor

When I cloned your repo and this branch and tried and do flutter update-packages, I got:

Because macrobenchmarks depends on e2e >=0.2.1 which requires Flutter SDK version >=1.6.7 <2.0.0, version solving failed.

I searched, it turns out that e2e is actually deprecated (source has been removed, but remains published) and replaced by integration_test, but replacing that didn't fix things.

I've reset a couple of times, and sometimes running flutter update-packages --force-upgrade fixes it, but not always. I'm trying to figure out the order of operations that works to give us a clue.

Do you get a similar problem locally?

@jakemac53
Copy link
Contributor Author

@gspencergoog no I am not seeing that issue locally

@jonahwilliams jonahwilliams mentioned this pull request Sep 23, 2020
13 tasks
@jakemac53
Copy link
Contributor Author

The internal google failure looks like a flake or unrelated breakage

@jakemac53 jakemac53 merged commit 9cee75b into flutter:master Sep 23, 2020
@jakemac53 jakemac53 deleted the update-null-safe-pkgs branch September 23, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants