Avoid labeling 'context' PRs as 'text-input' #157650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
the
c: contributor-productivity
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 28, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 28, 2024
flutter/flutter@5a11904...3fb95c7 2024-10-28 [email protected] Roll Flutter Engine from bf5bfeebf89f to 23b2c6d3b3b1 (3 revisions) (flutter/flutter#157736) 2024-10-28 [email protected] Avoid labeling 'context' PRs as 'text-input' (flutter/flutter#157650) 2024-10-28 [email protected] Add test for `restorable_route_future.0.dart` (flutter/flutter#157708) 2024-10-28 [email protected] Update .ci.yaml have android sdk be 35v1 (flutter/flutter#157621) 2024-10-28 [email protected] Roll Flutter Engine from 2522789c4199 to bf5bfeebf89f (1 revision) (flutter/flutter#157713) 2024-10-28 [email protected] Add test for `restoration_mixin.0.dart` (flutter/flutter#157709) 2024-10-28 [email protected] Add test for `navigator.restorable_push_replacement.0.dart` (flutter/flutter#157704) 2024-10-28 [email protected] Add test for `focus_node.unfocus.0.dart` (flutter/flutter#157673) 2024-10-28 [email protected] Roll Flutter Engine from 9226b089d634 to 2522789c4199 (2 revisions) (flutter/flutter#157710) 2024-10-28 [email protected] Add tests for `navigator_state.restorable_push.0.dart` (flutter/flutter#157667) 2024-10-28 [email protected] Roll Flutter Engine from 10e50bd42c42 to 9226b089d634 (1 revision) (flutter/flutter#157702) 2024-10-28 [email protected] Add test for `navigator_state.restorable_push_replacement.0.dart` (flutter/flutter#157668) 2024-10-28 [email protected] Remove unsafe_html lint rule (flutter/flutter#157531) 2024-10-27 [email protected] Roll Flutter Engine from 3162aaad0086 to 10e50bd42c42 (1 revision) (flutter/flutter#157690) 2024-10-27 [email protected] Fix Scaffold extend body (flutter/flutter#157441) 2024-10-26 [email protected] Roll Flutter Engine from c9b8ac96f6ce to 3162aaad0086 (3 revisions) (flutter/flutter#157681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
9 tasks
Member
Author
|
Reason for revert: this made the labeler go crazy and put it on everything that didn't contain "context". |
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
This reverts commit 4a46649.
9 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Oct 29, 2024
…7812) Reverts: #157650 Initiated by: jmagman Reason for reverting: this made the labeler go crazy and put it on everything that didn't contain "context". Original PR Author: jmagman Reviewed By: {christopherfujino} This change reverts the following previous change: #157646 is being labeled by the PR labeler as "text-input" because it edited "con**text**_runner.dart". ``` ##[debug] "**/*text*" pattern matched packages/flutter_tools/lib/src/context_runner.dart ``` https://github.com/flutter/flutter/actions/runs/11526508378/job/32090756495?pr=157646#step:2:134 Exclude the common "context" word from this label rule. See negation example at https://github.com/actions/labeler/blob/main/README.md#basic-examples.
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
After #157650 all PRs are being labeled as text-input by the PR labeler. I think the config is missing an `all` based on the [negation example](https://github.com/actions/labeler/blob/main/README.md#basic-examples)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#157646 is being labeled by the PR labeler as "text-input" because it edited "context_runner.dart".
https://github.com/flutter/flutter/actions/runs/11526508378/job/32090756495?pr=157646#step:2:134
Exclude the common "context" word from this label rule.
See negation example at https://github.com/actions/labeler/blob/main/README.md#basic-examples.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.