This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run benchmarks on try jobs. #9493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jun 26, 2019
Fixes flutter/flutter#35089. These runs only ensure that the benchmark harnesses are valid. No information should be collected on the trybots because the environments are not consistent and the builds are not optimized.
chinmaygarde
force-pushed
the
tryjob_bench
branch
from
6510423 to
2ff5745
Compare
Contributor
Author
|
The bot failures were because the benchmark harnesses were not AOT aware. This has been fixed. |
Contributor
Author
|
The failing framework test is expected as @GaryQian is doing a manual roll. Landing as all engine tests are green. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2019
This was referenced Jun 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2019
flutter/engine@185087a...4aaa1a9 git log 185087a..4aaa1a9 --no-merges --oneline 4aaa1a9 Roll src/third_party/skia 842e92e29216..b851469b8e96 (6 commits) (flutter/engine#9568) 4e48fc4 Switched preprocessor logic for exporting symbols for testing. (NDEBUG (flutter/engine#9562) 50a8e73 Has a binary messenger (flutter/engine#9419) 7483665 Re-enable embedder_unittests. (flutter/engine#9482) 773cf53 Roll fuchsia/sdk/core/linux-amd64 from SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C to N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC (flutter/engine#9560) c2fa689 Roll src/third_party/skia d8f79a27b06b..842e92e29216 (108 commits) (flutter/engine#9558) 00c023b Roll fuchsia/sdk/core/mac-amd64 from dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC to 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC (flutter/engine#9557) 7b9f59e Run benchmarks on try jobs. (flutter/engine#9493) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@185087a...4aaa1a9 git log 185087a..4aaa1a9 --no-merges --oneline 4aaa1a9 Roll src/third_party/skia 842e92e29216..b851469b8e96 (6 commits) (flutter/engine#9568) 4e48fc4 Switched preprocessor logic for exporting symbols for testing. (NDEBUG (flutter/engine#9562) 50a8e73 Has a binary messenger (flutter/engine#9419) 7483665 Re-enable embedder_unittests. (flutter/engine#9482) 773cf53 Roll fuchsia/sdk/core/linux-amd64 from SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C to N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC (flutter/engine#9560) c2fa689 Roll src/third_party/skia d8f79a27b06b..842e92e29216 (108 commits) (flutter/engine#9558) 00c023b Roll fuchsia/sdk/core/mac-amd64 from dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC to 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC (flutter/engine#9557) 7b9f59e Run benchmarks on try jobs. (flutter/engine#9493) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#35089.
These runs only ensure that the benchmark harnesses are valid. No information should be collected on the trybots because the environments are not consistent and the builds are not optimized.