This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for the Fontconfig-based Skia font manager #8977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
May 15, 2019
| declare_args() { | ||
| flutter_use_fontconfig = false | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Assert that you are on linux here as it is the only platform on which FC is supported.
Contributor
|
Presubmits are mad at the formatting of the GN files. |
jason-simmons
force-pushed
the
fontconfig_fontmgr
branch
from
e116852 to
4949bc3
Compare
Member
Author
|
Done - PTAL |
jason-simmons
force-pushed
the
fontconfig_fontmgr
branch
from
4949bc3 to
f9d5bf6
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
May 17, 2019
flutter/engine@859cd98...e94d352 git log 859cd98..e94d352 --no-merges --oneline e94d352 Roll src/third_party/dart cc2d5adec9..5ffff98440 (3 commits) 424940f Add support for the Fontconfig-based Skia font manager (flutter/engine#8977) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.