Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matthew-carroll
Copy link
Contributor

New Plugin API PR3: Introduces Service, BroadcastReceiver, and ContentProvider awareness, control surfaces, and plugin bindings.

In this PR I took the existing FlutterEnginePluginRegistry, which was defined within the FlutterEngine file, and broke it out to a package private standalone class. Most if its content is unchanged.

This PR repeats a structural process for Servicess, BroadcastReceivers, and ContentProviders that was done for Activitys in the previous PR:
#8943

…tProvider awareness, control surfaces, and plugin bindings.
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo some nits.

@matthew-carroll matthew-carroll merged commit c181972 into flutter:master May 17, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 17, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2019
…d ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request May 18, 2019
flutter/engine@065fe5b...db85261

git log 065fe5b..db85261 --no-merges --oneline
db85261 Roll src/third_party/skia 76346ac952c4..8c6bfe5350cf (2 commits) (flutter/engine#9008)
9bb8e32 Roll src/third_party/dart c6f6713de1..9e30fbaea4 (6 commits)
525e392 Roll src/third_party/dart b1f9f2182d..c6f6713de1 (4 commits)
d946e3e Rename Fuchsia Dart and Flutter runners (flutter/engine#9003)
197feb5 [fuchsia] Update zx_clock_get callers (flutter/engine#8998)
03f35e2 Roll src/third_party/dart b2a3d1c31b..b1f9f2182d (1 commits)
8840b75 Roll src/third_party/skia 0c6daf034b11..76346ac952c4 (30 commits) (flutter/engine#9000)
c181972 New Plugin API PR3: Introduces Service, BroadcastReceiver, and ContentProvider awareness, control surfaces, and plugin bindings. (flutter/engine#8962)
682a6a8 Roll src/third_party/dart 0e8656e045..b2a3d1c31b (2 commits)
74b1f32 Roll src/third_party/skia c6568afa0b63..0c6daf034b11 (1 commits) (flutter/engine#8995)
2e6ed7c Roll Buildroot (flutter/engine#8996)
865cb1c Roll src/third_party/dart 5ffff98440..0e8656e045 (1 commits)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
huqiuser pushed a commit to huqiuser/engine that referenced this pull request Jun 12, 2019
…tProvider awareness, control surfaces, and plugin bindings. (flutter#8962)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants