Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Ensure text fields are only live regions when they have input focus #6649

Merged
jonahwilliams merged 2 commits into from
Oct 25, 2018
Merged

Ensure text fields are only live regions when they have input focus #6649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5335f1
TextField is only a live region when it has input focus
jonahwilliams Oct 24, 2018
864faf2
Merge branch 'master' of github.com:flutter/engine into foobar
jonahwilliams Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shell/platform/android/io/flutter/view/AccessibilityBridge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,10 @@ public AccessibilityNodeInfo createAccessibilityNodeInfo(int virtualViewId) {
if (object.textSelectionBase != -1 && object.textSelectionExtent != -1) {
result.setTextSelection(object.textSelectionBase, object.textSelectionExtent);
}
// Text fields will always be created as a live region, so that updates to
// the label trigger polite announcements. This makes it easy to follow a11y
// guidelines for text fields on Android.
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.JELLY_BEAN_MR2) {
// Text fields will always be created as a live region when they have input focus,
// so that updates to the label trigger polite announcements. This makes it easy to
// follow a11y guidelines for text fields on Android.
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.JELLY_BEAN_MR2 && mA11yFocusedObject != null && mA11yFocusedObject.id == virtualViewId) {
result.setLiveRegion(View.ACCESSIBILITY_LIVE_REGION_POLITE);
}
}
Expand Down