This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Gate locale.getScript() behind version check for android API < 21 #6592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Oct 18, 2018
jason-simmons
approved these changes
Oct 18, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 18, 2018
flutter/engine@104f057...3860a43 git log 104f057..3860a43 --no-merges --oneline 3860a43 Re-revert wrong line_heights implementation (flutter/engine#6598) 09dcc3d Gate locale.getScript() behind version check for android API < 21 (flutter/engine#6592) c176244 Provide an estimate of EngineLayer memory usage to the Dart GC (flutter/engine#6589) 2511dec Roll src/third_party/skia a64e4eeaa357..b4ae49937d83 (14 commits) (flutter/engine#6590) 0887dd5 Roll buildroot to 4ee3892 (flutter/engine#6586) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
yjbanov
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 18, 2018
flutter/engine@104f057...3860a43 git log 104f057..3860a43 --no-merges --oneline 3860a43 Re-revert wrong line_heights implementation (flutter/engine#6598) 09dcc3d Gate locale.getScript() behind version check for android API < 21 (flutter/engine#6592) c176244 Provide an estimate of EngineLayer memory usage to the Dart GC (flutter/engine#6589) 2511dec Roll src/third_party/skia a64e4eeaa357..b4ae49937d83 (14 commits) (flutter/engine#6590) 0887dd5 Roll buildroot to 4ee3892 (flutter/engine#6586) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
|
You're still calling data is not used, instead a new List is created.And in the creation of the new list, there is still a call to Locale.getScript.
|
Contributor
Author
|
Oh yeah, you are right, I'll get that fixed! Thanks! |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locale.getScript() is introduced in API 21. Crashes on lower API devices without this check.