This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Pass Locale script code and variant code to dart:ui Window. #6493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryQian
changed the title
|
|
||
| const auto& language = args->value[0]; | ||
| const auto& country = args->value[1]; | ||
| const auto& script = args->value[2]; |
Member
There was a problem hiding this comment.
A bounds check on the args is necessary here. Android wont send these extra argument values currently.
Contributor
Author
There was a problem hiding this comment.
I changed it to send these values. See FlutterView.java:320
chinmaygarde
approved these changes
Oct 11, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2018
flutter/engine@daed2b7...f307c7f git log daed2b7..f307c7f --no-merges --oneline f307c7f Remove VM options that are on by default now. (flutter/engine#6495) 61cf4c0 Pass scriptcode and variantcode to dart:ui Window. (flutter/engine#6493) 0eda0cf Roll src/third_party/skia 04ac46135f23..9835dd51b320 (7 commits) (flutter/engine#6494) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2018
flutter/engine@daed2b7...f307c7f git log daed2b7..f307c7f --no-merges --oneline f307c7f Remove VM options that are on by default now. (flutter/engine#6495) 61cf4c0 Pass scriptcode and variantcode to dart:ui Window. (flutter/engine#6493) 0eda0cf Roll src/third_party/skia 04ac46135f23..9835dd51b320 (7 commits) (flutter/engine#6494) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locale needs to support scriptCode and variantCode. This passes these two values through the engine to the
Windowdart object but does not integrateLocalebecause #6481 has not yet landed.