Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "iOS: Migrate FlutterEngine to ARC" #55937

Merged
auto-submit merged 4 commits into from
Oct 17, 2024
Merged

Reland "iOS: Migrate FlutterEngine to ARC" #55937

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66b43e6
Reland "iOS: Migrate FlutterEngine to ARC"
cbracken Oct 15, 2024
8a3d143
Prevent FlutterEngine dtor running on background thread
cbracken Oct 17, 2024
e911384
Call loadView
cbracken Oct 17, 2024
4d521b3
review feedback: improve comment
cbracken Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/darwin/ios/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ source_set("flutter_framework_source_arc") {
"framework/Source/FlutterDartVMServicePublisher.mm",
"framework/Source/FlutterEmbedderKeyResponder.h",
"framework/Source/FlutterEmbedderKeyResponder.mm",
"framework/Source/FlutterEngine.mm",
"framework/Source/FlutterEngineGroup.mm",
"framework/Source/FlutterEngine_Internal.h",
"framework/Source/FlutterHeadlessDartRunner.mm",
"framework/Source/FlutterKeyPrimaryResponder.h",
"framework/Source/FlutterKeySecondaryResponder.h",
Expand Down Expand Up @@ -186,8 +188,6 @@ source_set("flutter_framework_source") {
# iOS embedder is migrating to ARC.
# New files are highly encouraged to be in ARC.
# To add new files in ARC, add them to the `flutter_framework_source_arc` target.
"framework/Source/FlutterEngine.mm",
"framework/Source/FlutterEngine_Internal.h",
"framework/Source/FlutterViewController.mm",
"framework/Source/FlutterViewController_Internal.h",
"platform_view_ios.h",
Expand Down
Loading