Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] migrate blend tests to DL. #54457

Merged
auto-submit merged 6 commits into from
Aug 10, 2024
Merged

[Impeller] migrate blend tests to DL. #54457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df44ce2
[Impeller] migrate blend tests to DL.
Aug 8, 2024
d855d78
++
Aug 9, 2024
11a986b
adjust sampling.
Aug 9, 2024
8bb7d1c
++
Aug 9, 2024
236eab5
bug fixes.
Aug 9, 2024
2635665
++
Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/licenses_golden/excluded_files
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@
../../../flutter/impeller/core/allocator_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_atlas_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_basic_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_blend_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_clip_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_gradient_unittests.cc
../../../flutter/impeller/display_list/aiks_dl_opacity_unittests.cc
Expand Down
6 changes: 3 additions & 3 deletions display_list/effects/dl_image_filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ class DlColorFilterImageFilter final : public DlImageFilter {
class DlLocalMatrixImageFilter final : public DlImageFilter {
public:
explicit DlLocalMatrixImageFilter(const SkMatrix& matrix,
std::shared_ptr<DlImageFilter> filter)
std::shared_ptr<const DlImageFilter> filter)
Copy link
Contributor Author

@jonahwilliams jonahwilliams Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change I can't pass a composed image filter here

: matrix_(matrix), image_filter_(std::move(filter)) {}
explicit DlLocalMatrixImageFilter(const DlLocalMatrixImageFilter* filter)
: DlLocalMatrixImageFilter(filter->matrix_, filter->image_filter_) {}
Expand All @@ -682,7 +682,7 @@ class DlLocalMatrixImageFilter final : public DlImageFilter {

const SkMatrix& matrix() const { return matrix_; }

const std::shared_ptr<DlImageFilter> image_filter() const {
const std::shared_ptr<const DlImageFilter> image_filter() const {
return image_filter_;
}

Expand Down Expand Up @@ -738,7 +738,7 @@ class DlLocalMatrixImageFilter final : public DlImageFilter {

private:
SkMatrix matrix_;
std::shared_ptr<DlImageFilter> image_filter_;
std::shared_ptr<const DlImageFilter> image_filter_;
};

} // namespace flutter
Expand Down
Loading