Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move impeller-cmake-example to flutter/third_party. #53589

Merged
auto-submit merged 2 commits into from
Jun 26, 2024
Merged

Move impeller-cmake-example to flutter/third_party. #53589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c89ab1
Move impeller-cmake-example to flutter/third_party.
matanlurey Jun 26, 2024
1ed29d3
++
matanlurey Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,7 @@ deps = {
'dep_type': 'cipd',
},

'src/third_party/impeller-cmake-example': {
'src/flutter/third_party/impeller-cmake-example': {
Copy link
Member

@bdero bdero Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one more change is needed for this actually

Copy link
Member

@bdero bdero Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this path needs to be updated:

engine/DEPS

Line 1139 in e03cf86

'third_party/impeller-cmake-example',

Copy link
Contributor Author

@matanlurey matanlurey Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, ack

Copy link
Contributor Author

@matanlurey matanlurey Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

'url': Var('flutter_git') + '/third_party/impeller-cmake-example.git' + '@' + '9f8298ec31dcbebbf019bd487888166abf2f55e6',
'condition': 'download_impeller_cmake_example',
},
Expand Down
2 changes: 1 addition & 1 deletion tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ def to_gn_wasm_args(args, gn_args):


def run_impeller_cmake(args):
impeller_cmake_dir = os.path.join('third_party', 'impeller-cmake-example')
impeller_cmake_dir = os.path.join('flutter', 'third_party', 'impeller-cmake-example')
if not os.path.isdir(os.path.join(SRC_ROOT, impeller_cmake_dir)):
print('The Impeller cmake example directory "{}" does not exist'.format(impeller_cmake_dir))
return 1
Expand Down