Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 16, 2024

Only run Fuschia tests in presubmit when CI or shell/platform/fuchsia/ files change.

@jmagman jmagman requested review from matanlurey and zanderso April 16, 2024 21:28
@jmagman jmagman self-assigned this Apr 16, 2024
- ci/clang_tidy.sh
- shell/platform/fuchsia/**
# TODO(https://github.com/flutter/flutter/issues/138559): Re-enable/delete.
# runIfNot:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove the commented out runIfNot code, since flutter/flutter#138559 is being investigated. I can do so though if @matanlurey prefers.

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is safe, unfortunately - if we change something that Fuchsia depends on we'll get a red tree.

If we're seeing serious latency or flaky problems though, perhaps we could decide this is worth it anyway. What's the rationale here?

@jmagman
Copy link
Member Author

jmagman commented Apr 22, 2024

What's the rationale here?

I should have filled out the description more thoroughly. I'm always seeing this run when I'm only touching the iOS embedder which would definitely not impact Fuchsia. However this change is way too aggressive:

In flutter/engine#47994, I accidentally broke the Fuchsia build, despite all of the checks passing (and using the new test: all check to additionally run post-submits as pre-submits). It was reverted in flutter/engine#48130.

I will close this in favor of getting runIfNot working with shell/platform/darwin/** flutter/flutter#138559

@jmagman jmagman closed this Apr 22, 2024
@matanlurey
Copy link
Contributor

I will close this in favor of getting runIfNot working with shell/platform/darwin/** flutter/flutter#138559

I think runIfNot was straight up deleted because it didn't work as folks expect. I should delete the remains.

@jmagman jmagman deleted the linux_fuchsia branch May 10, 2024 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants