Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] remove absorb opacity limit. #52160

Merged
auto-submit merged 3 commits into from
Apr 19, 2024
Merged

[Impeller] remove absorb opacity limit. #52160

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f65777f
[Impeller] remove absorb opacity limit.
Apr 16, 2024
a9810bd
Merge branch 'main' into remove_aborb_limit
Apr 18, 2024
1f1c6f3
Update blend_filter_contents.cc
Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions impeller/entity/contents/filters/blend_filter_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,8 +742,7 @@ std::optional<Entity> BlendFilterContents::RenderFilter(
}

if (blend_mode <= Entity::kLastPipelineBlendMode) {
if (inputs.size() == 1 && foreground_color_.has_value() &&
GetAbsorbOpacity() == ColorFilterContents::AbsorbOpacity::kYes) {
if (inputs.size() == 1 && foreground_color_.has_value()) {
return CreateForegroundPorterDuffBlend(
inputs[0], renderer, entity, coverage, foreground_color_.value(),
blend_mode_, GetAlpha(), GetAbsorbOpacity());
Expand All @@ -753,8 +752,7 @@ std::optional<Entity> BlendFilterContents::RenderFilter(
}

if (blend_mode <= Entity::kLastAdvancedBlendMode) {
if (inputs.size() == 1 && foreground_color_.has_value() &&
GetAbsorbOpacity() == ColorFilterContents::AbsorbOpacity::kYes) {
if (inputs.size() == 1 && foreground_color_.has_value()) {
return CreateForegroundAdvancedBlend(
inputs[0], renderer, entity, coverage, foreground_color_.value(),
blend_mode, GetAlpha(), GetAbsorbOpacity());
Expand Down