Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818)" #51835

Merged
auto-submit merged 1 commit into from
Apr 1, 2024
Merged

Reverts "[Impeller] Avoid loading redundant Vulkan extensions. (#51818)" #51835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion impeller/renderer/backend/vulkan/capabilities_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,14 @@ static const char* GetExtensionName(RequiredAndroidDeviceExtensionVK ext) {
case RequiredAndroidDeviceExtensionVK::
kANDROIDExternalMemoryAndroidHardwareBuffer:
return "VK_ANDROID_external_memory_android_hardware_buffer";
case RequiredAndroidDeviceExtensionVK::kKHRSamplerYcbcrConversion:
return VK_KHR_SAMPLER_YCBCR_CONVERSION_EXTENSION_NAME;
case RequiredAndroidDeviceExtensionVK::kKHRExternalMemory:
return VK_KHR_EXTERNAL_MEMORY_EXTENSION_NAME;
case RequiredAndroidDeviceExtensionVK::kEXTQueueFamilyForeign:
return VK_EXT_QUEUE_FAMILY_FOREIGN_EXTENSION_NAME;
case RequiredAndroidDeviceExtensionVK::kKHRDedicatedAllocation:
return VK_KHR_DEDICATED_ALLOCATION_EXTENSION_NAME;
case RequiredAndroidDeviceExtensionVK::kLast:
return "Unknown";
}
Expand Down Expand Up @@ -365,7 +373,9 @@ CapabilitiesVK::GetEnabledDeviceFeatures(
required.fillModeNonSolid = supported.fillModeNonSolid;
}
// VK_KHR_sampler_ycbcr_conversion features.
{
if (IsExtensionInList(
enabled_extensions.value(),
RequiredAndroidDeviceExtensionVK::kKHRSamplerYcbcrConversion)) {
auto& required =
required_chain
.get<vk::PhysicalDeviceSamplerYcbcrConversionFeaturesKHR>();
Expand Down
28 changes: 28 additions & 0 deletions impeller/renderer/backend/vulkan/capabilities_vk.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,34 @@ enum class RequiredAndroidDeviceExtensionVK : uint32_t {
///
kANDROIDExternalMemoryAndroidHardwareBuffer,

//----------------------------------------------------------------------------
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
///
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_sampler_ycbcr_conversion.html
///
kKHRSamplerYcbcrConversion,

//----------------------------------------------------------------------------
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
///
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_external_memory.html
///
kKHRExternalMemory,

//----------------------------------------------------------------------------
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
///
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_EXT_queue_family_foreign.html
///
kEXTQueueFamilyForeign,

//----------------------------------------------------------------------------
/// Dependency of kANDROIDExternalMemoryAndroidHardwareBuffer.
///
/// https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VK_KHR_dedicated_allocation.html
///
kKHRDedicatedAllocation,

kLast,
};

Expand Down