Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Fuchsia] Assert renders are only to the implicit view #51559

Merged
auto-submit merged 4 commits into from
Mar 21, 2024
Merged

[Fuchsia] Assert renders are only to the implicit view #51559

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d66940
[Fuchsia] Assert renders are only into the implicit view
loic-sharma Mar 20, 2024
ca06e10
Fix
loic-sharma Mar 20, 2024
a3948ea
Fix
loic-sharma Mar 20, 2024
bcf3892
Update shell/platform/fuchsia/flutter/external_view_embedder.cc
loic-sharma Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shell/platform/fuchsia/flutter/external_view_embedder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
// found in the LICENSE file.

#include "external_view_embedder.h"

#include <algorithm>
#include <cstdint>

#include "flutter/common/constants.h"
#include "flutter/fml/trace_event.h"
#include "third_party/skia/include/core/SkPicture.h"
#include "third_party/skia/include/core/SkSurface.h"
Expand Down Expand Up @@ -115,6 +117,10 @@ void ExternalViewEmbedder::BeginFrame(
void ExternalViewEmbedder::PrepareFlutterView(int64_t flutter_view_id,
SkISize frame_size,
double device_pixel_ratio) {
// TODO(team-fuchsia): Support multiple views. For now, Fuchsia can render
// only into the implicit view.
FML_DCHECK(flutter_view_id == flutter::kFlutterImplicitViewId);

// Reset for new view.
Reset();
frame_size_ = frame_size;
Expand Down