Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix: Complete Documentation for RasterStatus::kSkipAndRetry #44880

Merged
auto-submit merged 6 commits into from
Aug 25, 2023
Merged

Fix: Complete Documentation for RasterStatus::kSkipAndRetry #44880

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47c5505
docs: completed doc for RasterStatus::kSkipAndRetry
yatendra2001 Aug 20, 2023
b12b6e6
Merge branch 'main' into main
yatendra2001 Aug 21, 2023
8a90c0f
Merge branch 'main' into main
yatendra2001 Aug 21, 2023
46da82d
Merge branch 'flutter:main' into main
yatendra2001 Aug 24, 2023
c94cf17
fix: removed trailing spaces
yatendra2001 Aug 25, 2023
422b70e
Merge branch 'main' into main
yatendra2001 Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions flow/compositor_context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,11 @@ enum class RasterStatus {
// This is currently used to wait for the thread merger to merge
// the raster and platform threads.
//
// Since the thread merger may be disabled,
// Since the thread merger may be disabled, the system will proceed
Copy link
Contributor

@dkwingsmt dkwingsmt Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Since the thread merger may be disabled, the system will proceed
// Since the thread merger may be disabled, the system will proceed

// with separate threads for rasterization and platform tasks,
Copy link
Contributor

@dkwingsmt dkwingsmt Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// with separate threads for rasterization and platform tasks,
// with separate threads for rasterization and platform tasks,

// potentially leading to different performance characteristics.
kSkipAndRetry,
// Frame has been successfully rasterized, but "there are additional items in
// Frame has been successfully rasterized, but there are additional items in
// the pipeline waiting to be consumed. This is currently
// only used when thread configuration change occurs.
kEnqueuePipeline,
Expand Down