Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Remove duplicated code. #44024

Merged
auto-submit merged 2 commits into from
Jul 26, 2023
Merged

[Impeller] Remove duplicated code. #44024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32ab5e
Remove duplicated code
dnfield Jul 25, 2023
49626d7
Update color_source_contents.h
dnfield Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions impeller/entity/contents/color_source_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,4 @@ void ColorSourceContents::SetInheritedOpacity(Scalar opacity) {
inherited_opacity_ = opacity;
}

bool ColorSourceContents::ShouldRender(
const Entity& entity,
const std::optional<Rect>& stencil_coverage) const {
if (!stencil_coverage.has_value()) {
return false;
}
return Contents::ShouldRender(entity, stencil_coverage);
}

} // namespace impeller
4 changes: 0 additions & 4 deletions impeller/entity/contents/color_source_contents.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ class ColorSourceContents : public Contents {
// |Contents|
std::optional<Rect> GetCoverage(const Entity& entity) const override;

// |Contents|
bool ShouldRender(const Entity& entity,
const std::optional<Rect>& stencil_coverage) const override;

// |Contents|
bool CanInheritOpacity(const Entity& entity) const override;

Expand Down
9 changes: 0 additions & 9 deletions impeller/entity/contents/solid_color_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,6 @@ std::optional<Rect> SolidColorContents::GetCoverage(
return geometry->GetCoverage(entity.GetTransformation());
};

bool SolidColorContents::ShouldRender(
const Entity& entity,
const std::optional<Rect>& stencil_coverage) const {
if (!stencil_coverage.has_value()) {
return false;
}
return Contents::ShouldRender(entity, stencil_coverage);
}

bool SolidColorContents::Render(const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
Expand Down
4 changes: 0 additions & 4 deletions impeller/entity/contents/solid_color_contents.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ class SolidColorContents final : public ColorSourceContents {
// |Contents|
std::optional<Rect> GetCoverage(const Entity& entity) const override;

// |Contents|
bool ShouldRender(const Entity& entity,
const std::optional<Rect>& stencil_coverage) const override;

// |Contents|
bool Render(const ContentContext& renderer,
const Entity& entity,
Expand Down