Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] no-op fragment program on Android until it works. #43657

Merged
auto-submit merged 2 commits into from
Jul 13, 2023
Merged

[Impeller] no-op fragment program on Android until it works. #43657

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35a5dc1
[Impeller] no-op fragment program on Android until it works.
Jul 13, 2023
9223418
++
Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions impeller/entity/contents/runtime_effect_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,13 @@ bool RuntimeEffectContents::CanInheritOpacity(const Entity& entity) const {
bool RuntimeEffectContents::Render(const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
// TODO(jonahwilliams): FragmentProgram API is not fully wired up on Android.
// Disable until this is complete so that integration tests and benchmarks can
// run m3 applications.
#ifdef FML_OS_ANDROID
Copy link
Contributor

@chinmaygarde chinmaygarde Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just move this to the top and add a comment that this is a no-op while we wire things up?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return true;
#endif

auto context = renderer.GetContext();
auto library = context->GetShaderLibrary();

Expand Down