Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] set stencil attachment descriptor for runtime effect. #42054

Merged
auto-submit merged 4 commits into from
May 15, 2023
Merged

[Impeller] set stencil attachment descriptor for runtime effect. #42054

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13ed0c5
[Impeller] set stencil attachment descriptor for runtime effect.
May 15, 2023
442f6f9
add aiks test
May 15, 2023
c12c277
Merge branch 'master' of github.com:flutter/engine into shader_save_l…
May 15, 2023
e351eb7
Update aiks_unittests.cc
May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion impeller/entity/contents/runtime_effect_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ bool RuntimeEffectContents::Render(const ContentContext& renderer,
desc.SetVertexDescriptor(std::move(vertex_descriptor));
desc.SetColorAttachmentDescriptor(
0u, {.format = color_attachment_format, .blending_enabled = true});
desc.SetStencilAttachmentDescriptors({});

StencilAttachmentDescriptor stencil0;
stencil0.stencil_compare = CompareFunction::kEqual;
Copy link
Member

@bdero bdero May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stencil depth (you can get this from the Entity) should also be set here, otherwise any clips will cause the output to get discarded.

Copy link
Member

@bdero bdero May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, the "stencil_reference" field.

Copy link
Contributor Author

@jonahwilliams jonahwilliams May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also set this on the command below. its a bit hard to track though, I think ultimately all of this information needs to end up on the descriptor right?

Copy link
Member

@bdero bdero May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops, I missed that we're already setting it.

The reason we have the stencil ref on the command and not the pipeline descriptor is that it's a pipeline input, not a property that we need to hash and build new pipelines for.

desc.SetStencilAttachmentDescriptors(stencil0);
desc.SetStencilPixelFormat(stencil_attachment_format);

auto options = OptionsFromPassAndEntity(pass, entity);
Expand Down