This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Return fonts in a deterministic order. #41907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: fixes tests |
eyebrowsoffire
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
This was referenced May 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
May 11, 2023
…6554) Manual roll requested by [email protected] flutter/engine@a0925f1...f38f46f 2023-05-11 [email protected] Add pkg:protobuf as a dependency for testing/dart (flutter/engine#41938) 2023-05-11 [email protected] Roll Skia from 0c979da775be to ccf73af6ca91 (1 revision) (flutter/engine#41937) 2023-05-11 [email protected] Roll Skia from a12a999cbd09 to 0c979da775be (1 revision) (flutter/engine#41935) 2023-05-11 [email protected] Roll Skia from 9cbc2c578e10 to a12a999cbd09 (2 revisions) (flutter/engine#41933) 2023-05-11 [email protected] Roll Skia from 1a29bd9a0147 to 9cbc2c578e10 (10 revisions) (flutter/engine#41932) 2023-05-11 [email protected] Roll Fuchsia Mac SDK from a3rrULFaXlwS8mfjW... to 2tQjI0g3aDmjHAtMw... (flutter/engine#41931) 2023-05-11 [email protected] Return fonts in a deterministic order. (flutter/engine#41907) 2023-05-11 [email protected] Turn @staticInterop tear-off into closure (flutter/engine#41885) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from a3rrULFaXlwS to 2tQjI0g3aDmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2023
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…tter#126554) Manual roll requested by [email protected] flutter/engine@a0925f1...f38f46f 2023-05-11 [email protected] Add pkg:protobuf as a dependency for testing/dart (flutter/engine#41938) 2023-05-11 [email protected] Roll Skia from 0c979da775be to ccf73af6ca91 (1 revision) (flutter/engine#41937) 2023-05-11 [email protected] Roll Skia from a12a999cbd09 to 0c979da775be (1 revision) (flutter/engine#41935) 2023-05-11 [email protected] Roll Skia from 9cbc2c578e10 to a12a999cbd09 (2 revisions) (flutter/engine#41933) 2023-05-11 [email protected] Roll Skia from 1a29bd9a0147 to 9cbc2c578e10 (10 revisions) (flutter/engine#41932) 2023-05-11 [email protected] Roll Fuchsia Mac SDK from a3rrULFaXlwS8mfjW... to 2tQjI0g3aDmjHAtMw... (flutter/engine#41931) 2023-05-11 [email protected] Return fonts in a deterministic order. (flutter/engine#41907) 2023-05-11 [email protected] Turn @staticInterop tear-off into closure (flutter/engine#41885) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from a3rrULFaXlwS to 2tQjI0g3aDmj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure to return fonts in the order we passed them in, so that unit tests don't flake if they load in a different order.