This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix transform regressions for chained filters #41332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bdero
force-pushed
the
bdero/porterduff-transform
branch
from
c249398 to
5cdd279
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
force-pushed
the
bdero/porterduff-transform
branch
2 times, most recently
from
5f7f0be to
84e7e97
Compare
chinmaygarde
approved these changes
Apr 19, 2023
bdero
force-pushed
the
bdero/porterduff-transform
branch
from
0c86905 to
0754f38
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 19, 2023
flutter/engine@0a53cf6...d726345 2023-04-19 [email protected] [Impeller] Comprehensively label snapshots (flutter/engine#41325) 2023-04-19 [email protected] [Impeller] Fix transform regressions for chained filters (flutter/engine#41332) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
Author
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#124956.
Fixes some recent transform issues that mainly apply to chained filters (like when both a color + image filter has been set).
New golden:
Play/AiksTest.TranslucentSaveLayerWithColorFilterAndImageFilterDrawsCorrectly/MetalBefore:
After:
