Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove 'Mac mac_unopt' in favor of Linux #41226

Merged
auto-submit merged 4 commits into from
Apr 17, 2023
Merged

Remove 'Mac mac_unopt' in favor of Linux #41226

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0abe21
Remove 'Mac mac_unopt' in favor of Linux
jmagman Apr 14, 2023
8410d24
Try again with new builder
jmagman Apr 14, 2023
7e57265
Add sdk_version
jmagman Apr 17, 2023
ce1d903
Remove duplicate properties
jmagman Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,7 @@ targets:
$flutter/osx_sdk : >-
{ "sdk_version": "14a5294e" }

- name: Mac mac_unopt
recipe: engine_v2/engine_v2
properties:
config_name: mac_unopt
add_recipes_cq: "true"
timeout: 60

- name: Linux mac_unopt
bringup: true
recipe: engine_v2/engine_v2
properties:
config_name: mac_unopt
Expand Down
20 changes: 20 additions & 0 deletions ci/builders/mac_unopt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
"config": "host_debug_unopt",
"targets": []
},
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "14a5294e"
}
},
"tests": [
{
"language": "python3",
Expand Down Expand Up @@ -86,6 +91,11 @@
"flutter/shell/platform/darwin/ios:ios_test_flutter"
]
},
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "14a5294e"
}
},
Copy link
Contributor

@keyonghan keyonghan Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already included above.

Copy link
Member Author

@jmagman jmagman Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ thanks

"tests": [
{
"language": "python3",
Expand Down Expand Up @@ -145,6 +155,11 @@
"targets": [
]
},
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "14a5294e"
}
},
"tests": []
},
{
Expand Down Expand Up @@ -188,6 +203,11 @@
"flutter/shell/platform/darwin/ios:ios_test_flutter"
]
},
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "14a5294e"
}
},
Copy link
Contributor

@keyonghan keyonghan Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

"tests": [
{
"language": "python3",
Expand Down