This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Reduce code size impact of fallback font data #38787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
Contributor
Author
|
Do we want to move forward with this @hterkelsen @eyebrowsoffire ? |
harryterkelsen
approved these changes
Jan 13, 2023
| final int start = int.parse(starts[i], radix: 16); | ||
| final int end = int.parse(ends[i], radix: 16); | ||
|
|
||
| sb.write(start.toRadixString(36)); |
Contributor
There was a problem hiding this comment.
36 just to get maximum "compression"?
Contributor
Author
There was a problem hiding this comment.
Yes. To encode the integer in as few characters as possible.
Contributor
|
I tested this against the dart2wasm stuff and it doesn't cause anything to explode, so LGTM! |
Contributor
|
@mdebbar – make non-draft and land? |
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 18, 2023
* 5aee791 Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (flutter/engine#38883) * 78a68b9 Roll Skia from c64a10d525d1 to aa99fa0bdd31 (10 revisions) (flutter/engine#38886) * 398af8c Roll Fuchsia Mac SDK from w0hr1ZMvYGJnWInwK... to nPbEqgIfE8TLOokQH... (flutter/engine#38889) * 7035027 Roll Skia from aa99fa0bdd31 to 5a51583d09dd (2 revisions) (flutter/engine#38892) * 2075cf3 Roll Fuchsia Mac SDK from nPbEqgIfE8TLOokQH... to SmEVvAFBC8oriPBou... (flutter/engine#38897) * ef06ef6 Roll Skia from 5a51583d09dd to 34a14247bd4b (1 revision) (flutter/engine#38901) * 0d374a9 Roll Skia from 34a14247bd4b to c727016cc09e (1 revision) (flutter/engine#38903) * 31f2020 Roll Skia from c727016cc09e to 214411b09e92 (2 revisions) (flutter/engine#38907) * a3006de Bump actions/setup-python from 4.4.0 to 4.5.0 (flutter/engine#38909) * eacc09c Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/engine#38910) * c33c11c Roll Skia from 214411b09e92 to 3704033dd106 (1 revision) (flutter/engine#38908) * afa093d [Impeller] Map UVs correctly for TiledTextureContents (flutter/engine#38894) * 46ea2b3 Roll Fuchsia Mac SDK from SmEVvAFBC8oriPBou... to bZfX8KCoI3CfxEzsG... (flutter/engine#38912) * aadb971 Roll Skia from 3704033dd106 to 58e745419425 (4 revisions) (flutter/engine#38936) * 24b21a5 Roll Fuchsia Mac SDK from bZfX8KCoI3CfxEzsG... to iwCuzAuMgsk75hlT0... (flutter/engine#38938) * e655580 Roll Skia from 58e745419425 to 6afb97022fa7 (1 revision) (flutter/engine#38943) * 5932bad Revert "Revert "[web] Don't overwrite editing state with semantic updates (#38271)" (#38562)" (flutter/engine#38854) * 928772e [web] Reduce code size impact of fallback font data (flutter/engine#38787) * 88a8d9a Roll Skia from 6afb97022fa7 to 8ea9b39f7213 (18 revisions) (flutter/engine#38952) * 3a47943 Roll Skia from 8ea9b39f7213 to 69d8378097df (6 revisions) (flutter/engine#38953) * 641623a wrap focus() in a post update callback (flutter/engine#38958) * 7d71ee3 Roll Fuchsia Mac SDK from iwCuzAuMgsk75hlT0... to -1N2YUML8GqNhK8YP... (flutter/engine#38960) * d762142 reland fix canvas drawLine bugs (flutter/engine#38949) * 0d79533 [Impeller] Fix back-to-back clip restoration (flutter/engine#38964) * 19fe86c Update scenario screenshots to iOS 16 (flutter/engine#38962) * eb18ac0 Fix iOS safari keyboard issue when semantics is enabled (flutter/engine#38822) * 84a73d9 [Impeller Scene] Add SceneNodeValue for synchronously fetching loaded ipscenes (flutter/engine#38913) * 7bff5dd Revert "Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (#38883)" (flutter/engine#38973) * c52b290 Roll Fuchsia Mac SDK from -1N2YUML8GqNhK8YP... to P5QcCJU8I71xVXuMT... (flutter/engine#38976)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…18720) * 5aee791 Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (flutter/engine#38883) * 78a68b9 Roll Skia from c64a10d525d1 to aa99fa0bdd31 (10 revisions) (flutter/engine#38886) * 398af8c Roll Fuchsia Mac SDK from w0hr1ZMvYGJnWInwK... to nPbEqgIfE8TLOokQH... (flutter/engine#38889) * 7035027 Roll Skia from aa99fa0bdd31 to 5a51583d09dd (2 revisions) (flutter/engine#38892) * 2075cf3 Roll Fuchsia Mac SDK from nPbEqgIfE8TLOokQH... to SmEVvAFBC8oriPBou... (flutter/engine#38897) * ef06ef6 Roll Skia from 5a51583d09dd to 34a14247bd4b (1 revision) (flutter/engine#38901) * 0d374a9 Roll Skia from 34a14247bd4b to c727016cc09e (1 revision) (flutter/engine#38903) * 31f2020 Roll Skia from c727016cc09e to 214411b09e92 (2 revisions) (flutter/engine#38907) * a3006de Bump actions/setup-python from 4.4.0 to 4.5.0 (flutter/engine#38909) * eacc09c Bump github/codeql-action from 2.1.37 to 2.1.38 (flutter/engine#38910) * c33c11c Roll Skia from 214411b09e92 to 3704033dd106 (1 revision) (flutter/engine#38908) * afa093d [Impeller] Map UVs correctly for TiledTextureContents (flutter/engine#38894) * 46ea2b3 Roll Fuchsia Mac SDK from SmEVvAFBC8oriPBou... to bZfX8KCoI3CfxEzsG... (flutter/engine#38912) * aadb971 Roll Skia from 3704033dd106 to 58e745419425 (4 revisions) (flutter/engine#38936) * 24b21a5 Roll Fuchsia Mac SDK from bZfX8KCoI3CfxEzsG... to iwCuzAuMgsk75hlT0... (flutter/engine#38938) * e655580 Roll Skia from 58e745419425 to 6afb97022fa7 (1 revision) (flutter/engine#38943) * 5932bad Revert "Revert "[web] Don't overwrite editing state with semantic updates (flutter#38271)" (flutter#38562)" (flutter/engine#38854) * 928772e [web] Reduce code size impact of fallback font data (flutter/engine#38787) * 88a8d9a Roll Skia from 6afb97022fa7 to 8ea9b39f7213 (18 revisions) (flutter/engine#38952) * 3a47943 Roll Skia from 8ea9b39f7213 to 69d8378097df (6 revisions) (flutter/engine#38953) * 641623a wrap focus() in a post update callback (flutter/engine#38958) * 7d71ee3 Roll Fuchsia Mac SDK from iwCuzAuMgsk75hlT0... to -1N2YUML8GqNhK8YP... (flutter/engine#38960) * d762142 reland fix canvas drawLine bugs (flutter/engine#38949) * 0d79533 [Impeller] Fix back-to-back clip restoration (flutter/engine#38964) * 19fe86c Update scenario screenshots to iOS 16 (flutter/engine#38962) * eb18ac0 Fix iOS safari keyboard issue when semantics is enabled (flutter/engine#38822) * 84a73d9 [Impeller Scene] Add SceneNodeValue for synchronously fetching loaded ipscenes (flutter/engine#38913) * 7bff5dd Revert "Roll Dart SDK from 645fd748e79e to 0097dcbada06 (3 revisions) (flutter#38883)" (flutter/engine#38973) * c52b290 Roll Fuchsia Mac SDK from -1N2YUML8GqNhK8YP... to P5QcCJU8I71xVXuMT... (flutter/engine#38976)
ricardoamador
pushed a commit
to ricardoamador/engine
that referenced
this pull request
Jan 25, 2023
* [web] Reduce code size impact of fallback font data * fix rangeEnd vs rangeLength mistake
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes fallback font data introduced in #35646.
Counter app
Size of
main.dart.js:Related to flutter/flutter#113898