Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable UIA text/range provider unit tests #38718

Merged
yaakovschectman merged 2 commits into from
Jan 9, 2023
+48 −62
Merged

Re-enable UIA text/range provider unit tests #38718

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a1a155
Enable unit tests
yaakovschectman Jan 9, 2023
ec15001
Newline
yaakovschectman Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions third_party/accessibility/ax/platform/ax_platform_node_textprovider_win_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ class AXPlatformNodeTextProviderTest : public AXPlatformNodeWinTest {
}
};

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_CreateDegenerateRangeFromStart) {
TEST_F(AXPlatformNodeTextProviderTest, CreateDegenerateRangeFromStart) {
AXNodeData text1_data;
text1_data.id = 3;
text1_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -170,7 +169,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
text_content.Release();
}

TEST_F(AXPlatformNodeTextProviderTest, DISABLED_ITextProviderRangeFromChild) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderRangeFromChild) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -264,7 +263,7 @@ TEST_F(AXPlatformNodeTextProviderTest, DISABLED_ITextProviderRangeFromChild) {
}

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_ITextProviderRangeFromChildMultipleChildren) {
ITextProviderRangeFromChildMultipleChildren) {
const int ROOT_ID = 1;
const int DIALOG_ID = 2;
const int DIALOG_LABEL_ID = 3;
Expand Down Expand Up @@ -362,7 +361,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
EXPECT_EQ(enclosing_element.Get(), dialog_node_raw.Get());
}

TEST_F(AXPlatformNodeTextProviderTest, DISABLED_NearestTextIndexToPoint) {
TEST_F(AXPlatformNodeTextProviderTest, NearestTextIndexToPoint) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kInlineTextBox;
Expand Down Expand Up @@ -420,7 +419,7 @@ TEST_F(AXPlatformNodeTextProviderTest, DISABLED_NearestTextIndexToPoint) {
}
}

TEST_F(AXPlatformNodeTextProviderTest, DISABLED_ITextProviderDocumentRange) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderDocumentRange) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -556,8 +555,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
EXPECT_EQ(*GetEnd(text_range.Get()), *expected_end);
}

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_ITextProviderDocumentRangeNested) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderDocumentRangeNested) {
AXNodeData text_data;
text_data.id = 3;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -588,8 +586,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
text_provider->get_DocumentRange(&text_range_provider));
}

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_ITextProviderSupportedSelection) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderSupportedSelection) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand All @@ -616,7 +613,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
EXPECT_EQ(text_selection_mode, SupportedTextSelection_Single);
}

TEST_F(AXPlatformNodeTextProviderTest, DISABLED_ITextProviderGetSelection) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderGetSelection) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -826,8 +823,7 @@ TEST_F(AXPlatformNodeTextProviderTest, DISABLED_ITextProviderGetSelection) {
text_edit_provider->GetSelection(selections.Receive()));
}

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_ITextProviderGetActiveComposition) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderGetActiveComposition) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -887,8 +883,7 @@ TEST_F(AXPlatformNodeTextProviderTest,
EXPECT_EQ(*GetEnd(actual_range.Get()), *expected_end);
}

TEST_F(AXPlatformNodeTextProviderTest,
DISABLED_ITextProviderGetConversionTarget) {
TEST_F(AXPlatformNodeTextProviderTest, ITextProviderGetConversionTarget) {
AXNodeData text_data;
text_data.id = 2;
text_data.role = ax::mojom::Role::kStaticText;
Expand Down Expand Up @@ -948,4 +943,4 @@ TEST_F(AXPlatformNodeTextProviderTest,
EXPECT_EQ(*GetEnd(actual_range.Get()), *expected_end);
}

} // namespace ui
} // namespace ui
Copy link
Member

@loic-sharma loic-sharma Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the style guide requires that files end with an empty line.

See this as for why: https://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-a-source-file

Loading