[Impeller Scene] Depth attachment; baked lighting example #38118

bdero · 2022-12-07T11:16:39Z

Screen.Recording.2022-12-07.at.2.26.23.AM.mov

Impeller stuff:

Add combined depth+stencil texture formats. The depth + stencil texture must be the same on Metal ARM devices and Vulkan.
Allow un-setting RenderTarget depth and stencil attachments.
Remove an ImGui playground stencil attachment hack for passing validation that I added long ago (FYI @iskakaushik). The ImGui pipeline doesn't have a stencil, it uses the scissor for clipping.

Scene stuff:

Setup depth/stencil attachments
Allow for configuring the vertex color weight in the unlit material.
Add a texture to the example with baked lighting to test UVs.

The texture is 512x512 and 266k. What was your go to PNG compression tool @chinmaygarde?

Screenshot of the model with a baked 1024x1024 texture:

Notice the texture is mapped opposite to the geometry in Impeller Scene. We're decoding the geometry into the wrong space!

And a quick Iray render with 2048x2048 PBR textures against an HDRI:

Also, here are some fun screen grabs from before the color and depth were fixed:

zanderso · 2022-12-07T16:46:42Z

impeller/fixtures/BUILD.gn

    "table_mountain_py.png",
    "table_mountain_pz.png",
    "test_texture.frag",
+    "flutter_logo_baked.png",


nit: alphabetize.

The formatter apparently only sorts DEPS and sources since it can't tell if the items in the custom template are order sensitive. There is a NOSORT directive to disable sorting. Maybe we should patch GN to add a SORT directive to the formatter.

Done wrt alphabetizing.

chinmaygarde · 2022-12-07T20:36:29Z

What was your go to PNG compression tool?

pngcrush -ow -brute foo.png

chinmaygarde

Exciting!

chinmaygarde · 2022-12-07T19:05:07Z

impeller/renderer/formats.h

+
+  // Depth and stencil formats.
  kS8UInt,
+  kD32FloatS8UInt,


lol, I didn't realize we didn't have one of these already.

I never noticed either. For the depth in impeller-cmake I literally used B8G8R8A8 because it's GLES only right now and the attachments have no affect on the surface framebuffer. 😄

chinmaygarde · 2022-12-07T20:38:48Z

impeller/fixtures/BUILD.gn

    "table_mountain_py.png",
    "table_mountain_pz.png",
    "test_texture.frag",
+    "flutter_logo_baked.png",


The formatter apparently only sorts DEPS and sources since it can't tell if the items in the custom template are order sensitive. There is a NOSORT directive to disable sorting. Maybe we should patch GN to add a SORT directive to the formatter.

bdero · 2022-12-07T21:20:51Z

❯ ls -lh impeller/fixtures/flutter_logo_baked.png
-rw-r--r--@ 2 bdero  primarygroup   266K Dec  6 20:56 impeller/fixtures/flutter_logo_baked.png
❯ pngcrush -ow -brute impeller/fixtures/flutter_logo_baked.png
  Recompressing IDAT chunks in impeller/fixtures/flutter_logo_baked.png
   Total length of data found in critical chunks            =    272306
   Best pngcrush method        = 124 (ws 15 fm 5 zl 9 zs 1) =    269195
CPU time decode 0.767569, encode 5.304494, other 0.021383, total 6.099856 sec
❯ ls -lh impeller/fixtures/flutter_logo_baked.png
-rw-r--r--@ 1 bdero  primarygroup   263K Dec  7 13:13 impeller/fixtures/flutter_logo_baked.png

Looks like it found a way to save 3k on this image. 👍
I bet we'll be able to compress the maps with less detailed PBR channels a lot more when I eventually add them for testing purposes.

jpegs seem like an appropriate option for these test images as well.

…utter/engine#38118)

* bd8bcf9 Roll Fuchsia Mac SDK from crEcyXdyZ686cAqMV... to pMV6A0ykZQ8aA3NG2... (flutter/engine#38120) * dec8b52 Preliminary implementation of UIA for A11y on Windows (flutter/engine#37754) * 5545ccf Roll Fuchsia Linux SDK from NlJGkMbtZqQ6_BCpu... to xn8ztWtp-zww-jObz... (flutter/engine#38122) * 80a15a4 Create FlutterActivity/FlutterFragment using light weight engine with FlutterEngineGroup (flutter/engine#36963) * 5caef85 Full implementation of text-input-test (flutter/engine#37986) * 8f6036e Reland fix wrong VSYNC event (flutter/engine#37865) * 4101c36 [iOS] Change locale format for spell check (flutter/engine#38080) * 2f5b67e [embedder] Ensure destruction called on present (flutter/engine#38078) * 0bddc60 [Impeller Scene] Depth attachment; baked lighting example (flutter/engine#38118) * 6aa4ccd Remove dlCanvasRecorder from flutter::PictureRecorder (flutter/engine#38127) * dbb5284 [Windows] Add more cursor plugin tests (flutter/engine#38112) * 6e91204 Roll Fuchsia Mac SDK from pMV6A0ykZQ8aA3NG2... to 9SnrQ0vbR8IC7UIoP... (flutter/engine#38135) * 3140ad9 [Impeller] order metal samplers according to declared order and not usage order (flutter/engine#38115) * 84abf21 Remove autoninja. (flutter/engine#38136) * 8a113d3 [embedder] Expose metal surface from test context (flutter/engine#38133) * 1ef25b6 Roll Fuchsia Mac SDK from 9SnrQ0vbR8IC7UIoP... to aMW0DjntzFJj4RoR3... (flutter/engine#38139) * 748b3bc Revert "Remove dlCanvasRecorder from flutter::PictureRecorder (#38127)" (flutter/engine#38137) * b6daf3d [embedder] Consistent naming for GL/Metal tests (flutter/engine#38141) * 339d04b [web] Trivial fix for non-static interop JS interop class. (flutter/engine#38126) * 1fcbb9c [tools] Eliminate version on Obj-C docs (flutter/engine#38145) * 71928b6 [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke (flutter/engine#38146) * 23ce8fd Roll Skia from dd3285a80b23 to f84dc9303045 (4 revisions) (flutter/engine#38123) * 366f866 Roll Skia from f84dc9303045 to 2691cd7b4110 (40 revisions) (flutter/engine#38151) * 447e701 Roll Skia from 2691cd7b4110 to 711396b81248 (1 revision) (flutter/engine#38152) * cd5d91b Pylint testing/run_tests.py (flutter/engine#38016) * aafac08 Roll Skia from 711396b81248 to b253b10374e7 (7 revisions) (flutter/engine#38157) * 799dc78 Roll Fuchsia Linux SDK from xn8ztWtp-zww-jObz... to rRJIjuO-dPNCpCTd9... (flutter/engine#38134) * 3aa3d2a Massage the JS interop around `didCreateEngineInitializer` (flutter/engine#38147) * 030950f Roll Skia from b253b10374e7 to ec407902999b (3 revisions) (flutter/engine#38158)

…16802) * bd8bcf9 Roll Fuchsia Mac SDK from crEcyXdyZ686cAqMV... to pMV6A0ykZQ8aA3NG2... (flutter/engine#38120) * dec8b52 Preliminary implementation of UIA for A11y on Windows (flutter/engine#37754) * 5545ccf Roll Fuchsia Linux SDK from NlJGkMbtZqQ6_BCpu... to xn8ztWtp-zww-jObz... (flutter/engine#38122) * 80a15a4 Create FlutterActivity/FlutterFragment using light weight engine with FlutterEngineGroup (flutter/engine#36963) * 5caef85 Full implementation of text-input-test (flutter/engine#37986) * 8f6036e Reland fix wrong VSYNC event (flutter/engine#37865) * 4101c36 [iOS] Change locale format for spell check (flutter/engine#38080) * 2f5b67e [embedder] Ensure destruction called on present (flutter/engine#38078) * 0bddc60 [Impeller Scene] Depth attachment; baked lighting example (flutter/engine#38118) * 6aa4ccd Remove dlCanvasRecorder from flutter::PictureRecorder (flutter/engine#38127) * dbb5284 [Windows] Add more cursor plugin tests (flutter/engine#38112) * 6e91204 Roll Fuchsia Mac SDK from pMV6A0ykZQ8aA3NG2... to 9SnrQ0vbR8IC7UIoP... (flutter/engine#38135) * 3140ad9 [Impeller] order metal samplers according to declared order and not usage order (flutter/engine#38115) * 84abf21 Remove autoninja. (flutter/engine#38136) * 8a113d3 [embedder] Expose metal surface from test context (flutter/engine#38133) * 1ef25b6 Roll Fuchsia Mac SDK from 9SnrQ0vbR8IC7UIoP... to aMW0DjntzFJj4RoR3... (flutter/engine#38139) * 748b3bc Revert "Remove dlCanvasRecorder from flutter::PictureRecorder (flutter#38127)" (flutter/engine#38137) * b6daf3d [embedder] Consistent naming for GL/Metal tests (flutter/engine#38141) * 339d04b [web] Trivial fix for non-static interop JS interop class. (flutter/engine#38126) * 1fcbb9c [tools] Eliminate version on Obj-C docs (flutter/engine#38145) * 71928b6 [Impeller] Use DrawPath instead of Rect geometry when the paint style is stroke (flutter/engine#38146) * 23ce8fd Roll Skia from dd3285a80b23 to f84dc9303045 (4 revisions) (flutter/engine#38123) * 366f866 Roll Skia from f84dc9303045 to 2691cd7b4110 (40 revisions) (flutter/engine#38151) * 447e701 Roll Skia from 2691cd7b4110 to 711396b81248 (1 revision) (flutter/engine#38152) * cd5d91b Pylint testing/run_tests.py (flutter/engine#38016) * aafac08 Roll Skia from 711396b81248 to b253b10374e7 (7 revisions) (flutter/engine#38157) * 799dc78 Roll Fuchsia Linux SDK from xn8ztWtp-zww-jObz... to rRJIjuO-dPNCpCTd9... (flutter/engine#38134) * 3aa3d2a Massage the JS interop around `didCreateEngineInitializer` (flutter/engine#38147) * 030950f Roll Skia from b253b10374e7 to ec407902999b (3 revisions) (flutter/engine#38158)

bdero added the e: impeller label Dec 7, 2022

bdero requested review from chinmaygarde and zanderso December 7, 2022 11:16

bdero self-assigned this Dec 7, 2022

[Impeller Scene] Depth buffer; baked lighting example

6929e31

bdero force-pushed the bdero/ipscene-baked-light-texture branch from 107dab4 to 6929e31 Compare December 7, 2022 11:20

bdero added 2 commits December 7, 2022 03:25

vk formats

8be7c01

Remove kD24UNormS8UInt

658c260

bdero force-pushed the bdero/ipscene-baked-light-texture branch from 43190cc to 658c260 Compare December 7, 2022 11:39

zanderso reviewed Dec 7, 2022

View reviewed changes

chinmaygarde approved these changes Dec 7, 2022

View reviewed changes

Address comments

b5ffc04

bdero added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 7, 2022

auto-submit bot merged commit 0bddc60 into flutter:main Dec 7, 2022

engine-flutter-autoroll mentioned this pull request Dec 9, 2022

Roll Flutter Engine from 8d83b98c55b3 to 030950f3070c (29 revisions) flutter/flutter#116802

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 9, 2022

0bddc60 [Impeller Scene] Depth attachment; baked lighting example (fl…

50cba7d

…utter/engine#38118)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller Scene] Depth attachment; baked lighting example #38118

[Impeller Scene] Depth attachment; baked lighting example #38118

Uh oh!

bdero commented Dec 7, 2022

Uh oh!

zanderso Dec 7, 2022

Uh oh!

chinmaygarde Dec 7, 2022

Uh oh!

bdero Dec 7, 2022

Uh oh!

chinmaygarde commented Dec 7, 2022

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde Dec 7, 2022

Uh oh!

bdero Dec 7, 2022 •

edited

Loading

Uh oh!

chinmaygarde Dec 7, 2022

Uh oh!

bdero commented Dec 7, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Impeller Scene] Depth attachment; baked lighting example #38118

[Impeller Scene] Depth attachment; baked lighting example #38118

Uh oh!

Conversation

bdero commented Dec 7, 2022

Uh oh!

zanderso Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

bdero Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Dec 7, 2022

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

bdero Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

bdero commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bdero Dec 7, 2022 •

edited

Loading

bdero commented Dec 7, 2022 •

edited

Loading