This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix "unexpected masked action" assertion crash #37584
Merged
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moffatman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2022
* 9cf107b Revert "Fix wrong `VSYNC` event (#36775)" (flutter/engine#37589) * 8c73fff Fix unexpected masked action (flutter/engine#37584)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…5302) * 9cf107b Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589) * 8c73fff Fix unexpected masked action (flutter/engine#37584)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…5302) * 9cf107b Revert "Fix wrong `VSYNC` event (flutter#36775)" (flutter/engine#37589) * 8c73fff Fix unexpected masked action (flutter/engine#37584)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #34060 I changed a
return -1to an assertion, this was a mistake. The returning -1 was correct, the events with those values get filtered out inaddPointerForIndexlater on. It's the correct behaviour to skip events we don't understand rather than crashing.Fixes #111068
Pre-launch Checklist
///).