This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Don't double-convert include path encodings in ImpellerC #37408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
reviewed
Nov 8, 2022
| // fml::OpenDirectoryReadOnly for Windows doesn't handle relative paths | ||
| // beginning with `../` well, so we build an absolute path. | ||
|
|
||
| // Get the current working directory as a utf8 encoded string. |
Member
There was a problem hiding this comment.
Can this be unit tested in compiler_unittests.cc?
bdero
force-pushed
the
bdero/dont-double-encode-includes
branch
from
8fd6719 to
523e0ba
Compare
bdero
force-pushed
the
bdero/dont-double-encode-includes
branch
from
5416ac4 to
28c4982
Compare
zanderso
approved these changes
Nov 8, 2022
|
Gold has detected about 72 new digest(s) on patchset 3. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2022
* 6daa75a Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8 Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c4 Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154e Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (#37395)" (flutter/engine#37449) * c171f27 Revert "Add rects to accumulator rather than bounds (#37435)" (flutter/engine#37444) * 583c71c Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648 Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a8 Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070 Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc72934 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3e Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be [Reland] Add rects to accumulator rather than bounds (#37435) (flutter/engine#37451) * 214b841 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c9 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bf Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df76 Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee4 Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4a Roll expat to 2.5.0 (flutter/engine#37383) * ddde830 [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581e Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…15025) * 6daa75a Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8 Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c4 Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154e Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter#37395)" (flutter/engine#37449) * c171f27 Revert "Add rects to accumulator rather than bounds (flutter#37435)" (flutter/engine#37444) * 583c71c Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648 Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a8 Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070 Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc72934 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3e Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be [Reland] Add rects to accumulator rather than bounds (flutter#37435) (flutter/engine#37451) * 214b841 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c9 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bf Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df76 Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee4 Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4a Roll expat to 2.5.0 (flutter/engine#37383) * ddde830 [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581e Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…15025) * 6daa75a Roll Skia from 0c8127b3dd7d to 6a056a26b3c5 (16 revisions) (flutter/engine#37438) * 6517ee8 Roll Skia from 6a056a26b3c5 to 3cecb22c5827 (1 revision) (flutter/engine#37439) * c1200c4 Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter/engine#37395) * 179154e Revert "Sdk roll failure - add facet to allowlist test_manager and other packages. (flutter#37395)" (flutter/engine#37449) * c171f27 Revert "Add rects to accumulator rather than bounds (flutter#37435)" (flutter/engine#37444) * 583c71c Clang-tidy: Fixed math on shard-id validator. (flutter/engine#37433) * d224648 Roll Skia from 3cecb22c5827 to 94450cd1df4e (4 revisions) (flutter/engine#37445) * 5df42a8 Oops, accidentally compiled the non-null-safe platform file as null safe. (flutter/engine#37453) * 05455ac Roll Skia from 94450cd1df4e to 22526b55be02 (6 revisions) (flutter/engine#37455) * 9628070 Roll Skia from 22526b55be02 to 511aa59461f3 (1 revision) (flutter/engine#37458) * fc72934 [Impeller] Don't double-convert include path encodings in ImpellerC (flutter/engine#37408) * d82a2df Roll Skia from 511aa59461f3 to 790aedd91cd8 (2 revisions) (flutter/engine#37463) * be54e3e Roll Skia from 790aedd91cd8 to fe143a0dc368 (3 revisions) (flutter/engine#37467) * 410f270 Roll Dart SDK from c15cdb978761 to 874a662f7507 (3 revisions) (flutter/engine#37466) * e778ca4 Roll Fuchsia Mac SDK from d4l6A1aPw6Z0YjxmA... to vEw8iuSZYmlfk1JiE... (flutter/engine#37468) * f8048be [Reland] Add rects to accumulator rather than bounds (flutter#37435) (flutter/engine#37451) * 214b841 Roll Dart SDK from 874a662f7507 to 4fcefaf03496 (1 revision) (flutter/engine#37470) * 8ecb1c9 [macOS] Remove OpenGL rendering backend (flutter/engine#37448) * 1a8888b Roll Skia from fe143a0dc368 to 0854badd5783 (1 revision) (flutter/engine#37471) * ca303bf Roll Dart SDK from 4fcefaf03496 to fa6586382e5d (1 revision) (flutter/engine#37473) * 5d0df76 Use traingle strip for difference clip (flutter/engine#37469) * eeba9b3 Support HLSL ingestion in ImpellerC (flutter/engine#37461) * 5f88ee4 Use IndexError.check instead of RangeError.checkValidIndex in buffers. (flutter/engine#37450) * b65ac4a Roll expat to 2.5.0 (flutter/engine#37383) * ddde830 [sdk_roll_failure] add facet to allowlist test_manager and other packages. (flutter/engine#37479) * 62b581e Roll CanvasKit to 0.37.1 (flutter/engine#37454) * aa4b3ea Turned on performance-unnecessary-value-param everywhere. (flutter/engine#37447)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the Windows-only customer test failure in flutter/flutter#114214.
It turns out that we were mangling includes with non-ascii unicode characters due to double encoding because:
fml::CommandLinealready converts utf16 paths to utf8 on Windows, andpath::u8string()assumes the underlying path encoding is the native path encoding (and in this case it wasn't, because the paths were already encoded as utf8).