This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add DOM TouchEvent modifiers accessors #36836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
bleroux
changed the title
dkwingsmt
reviewed
Oct 18, 2022
| } | ||
| } | ||
|
|
||
| mixin _KeyboardModifiersMixin on _BasicEventContext { |
Contributor
There was a problem hiding this comment.
My memory to this file is getting vague, but since this mixin is used for all three event classes, can we just add these new properties to _BasicEventContext?
Contributor
Author
There was a problem hiding this comment.
can we just add these new properties to
_BasicEventContext?
Done, my first implementation was more complex so I did not want to clutter _BasicEventContent.
bleroux
added
the
autosubmit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds modifiers accessors (
altKey,ctrlKey,metaKey,shiftKey) toDomTouchEventExtension, as defined in the current W3C specification: https://www.w3.org/TR/touch-events/#attributes-2Motivation
Those accessors are needed to implement #36724.
See this review comment: #36724 (review).
Related Issue
Fixes flutter/flutter#113605
Tests
Update 3 tests