Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso requested review from godofredoc and jmagman August 24, 2022 20:13
@jmagman
Copy link
Member

jmagman commented Aug 24, 2022

@godofredoc

02:00 +18 -1: test/codesign_integration_test.dart: validate the expected binaries from the conductor codesign command are present in the cache [E]                                                     
  Found unexpected binary in cache: /opt/s/w/ir/x/t/flutter_conductor_integration_test.5zyvJH/flutter_conductor_checkouts/framework/bin/cache/artifacts/engine/darwin-x64-profile/FlutterMacOS.framework/FlutterMacOS.framework/Versions/A/FlutterMacOS
  package:test_api                          fail
  test/codesign_integration_test.dart 71:7  main.<fn>

This is probably the symlink issue?

@zanderso zanderso merged commit 1c5c705 into main Aug 24, 2022
@zanderso zanderso deleted the revert-35623-zip_framework branch August 24, 2022 20:24
@godofredoc
Copy link
Contributor

@godofredoc

02:00 +18 -1: test/codesign_integration_test.dart: validate the expected binaries from the conductor codesign command are present in the cache [E]                                                     
  Found unexpected binary in cache: /opt/s/w/ir/x/t/flutter_conductor_integration_test.5zyvJH/flutter_conductor_checkouts/framework/bin/cache/artifacts/engine/darwin-x64-profile/FlutterMacOS.framework/FlutterMacOS.framework/Versions/A/FlutterMacOS
  package:test_api                          fail
  test/codesign_integration_test.dart 71:7  main.<fn>

This is probably the symlink issue?

I would not expect this to impact try or prod builders. This zip file is only used by engine v2 builders

@jmagman
Copy link
Member

jmagman commented Aug 24, 2022

Hm, it did leak into try. As for the original issue, maybe zip needs -y flag to keep the symlinks?

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 24, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Aug 24, 2022
* fa86e2d Zip FlutterMacOS.framework. (flutter/engine#35623)

* ce987d4 Roll Dart SDK from 859e9bbe6f0a to 691aa6246705 (1 revision) (flutter/engine#35672)

* ab35696 Roll Skia from d965473d8719 to f0593b093a72 (2 revisions) (flutter/engine#35675)

* 4740824 [fuchsia] Document `found != flatland_views.end()`. (flutter/engine#35607)

* c6c8721 Roll Skia from f0593b093a72 to 8acbc3ce4e84 (7 revisions) (flutter/engine#35676)

* 7417091 Set temporary GN arg for Skia roll (flutter/engine#35651)

* 1c5c705 Revert "Zip FlutterMacOS.framework. (#35623)" (flutter/engine#35680)

* 983e3ab [Impeller] Fix matrix printing (flutter/engine#35656)

* c9876d7 Roll Fuchsia Mac SDK from XrmzJCUPGAd4klJlw... to uiiEV3lEQoosICL43... (flutter/engine#35677)
GaryQian pushed a commit to GaryQian/engine that referenced this pull request Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants