Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

use SkMatrix.invert() instead of MatrixDecomposition to validate cache matrices #29530

Merged
fluttergithubbot merged 3 commits into from
Nov 4, 2021
Merged

use SkMatrix.invert() instead of MatrixDecomposition to validate cache matrices #29530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f583e5
use SkMatrix.invert() instead of MatrixDecomposition to validate cach…
flar Nov 4, 2021
9f6024f
add unit tests
flar Nov 4, 2021
91e19f6
remove unused MatrixDecomposition classes and files
flar Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ci/licenses_golden/licenses_flutter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ FILE: ../../../flutter/flow/layers/texture_layer_unittests.cc
FILE: ../../../flutter/flow/layers/transform_layer.cc
FILE: ../../../flutter/flow/layers/transform_layer.h
FILE: ../../../flutter/flow/layers/transform_layer_unittests.cc
FILE: ../../../flutter/flow/matrix_decomposition.cc
FILE: ../../../flutter/flow/matrix_decomposition.h
FILE: ../../../flutter/flow/matrix_decomposition_unittests.cc
FILE: ../../../flutter/flow/mutators_stack_unittests.cc
FILE: ../../../flutter/flow/paint_region.cc
FILE: ../../../flutter/flow/paint_region.h
Expand Down
3 changes: 0 additions & 3 deletions flow/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ source_set("flow") {
"layers/texture_layer.h",
"layers/transform_layer.cc",
"layers/transform_layer.h",
"matrix_decomposition.cc",
"matrix_decomposition.h",
"paint_region.cc",
"paint_region.h",
"paint_utils.cc",
Expand Down Expand Up @@ -160,7 +158,6 @@ if (enable_unittests) {
"layers/shader_mask_layer_unittests.cc",
"layers/texture_layer_unittests.cc",
"layers/transform_layer_unittests.cc",
"matrix_decomposition_unittests.cc",
"mutators_stack_unittests.cc",
"raster_cache_unittests.cc",
"rtree_unittests.cc",
Expand Down
128 changes: 0 additions & 128 deletions flow/matrix_decomposition.cc
View file
Open in desktop

This file was deleted.

50 changes: 0 additions & 50 deletions flow/matrix_decomposition.h
View file
Open in desktop

This file was deleted.

159 changes: 0 additions & 159 deletions flow/matrix_decomposition_unittests.cc
View file
Open in desktop

This file was deleted.

12 changes: 2 additions & 10 deletions flow/raster_cache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,7 @@ bool RasterCache::Prepare(PrerollContext* context,
SkMatrix transformation_matrix = untranslated_matrix;
transformation_matrix.preTranslate(offset.x(), offset.y());

// Decompose the matrix (once) for all subsequent operations. We want to make
// sure to avoid volumetric distortions while accounting for scaling.
const MatrixDecomposition matrix(transformation_matrix);

if (!matrix.IsValid()) {
if (!transformation_matrix.invert(nullptr)) {
// The matrix was singular. No point in going further.
return false;
}
Expand Down Expand Up @@ -285,11 +281,7 @@ bool RasterCache::Prepare(PrerollContext* context,
SkMatrix transformation_matrix = untranslated_matrix;
transformation_matrix.preTranslate(offset.x(), offset.y());

// Decompose the matrix (once) for all subsequent operations. We want to make
// sure to avoid volumetric distortions while accounting for scaling.
const MatrixDecomposition matrix(transformation_matrix);

if (!matrix.IsValid()) {
if (!transformation_matrix.invert(nullptr)) {
// The matrix was singular. No point in going further.
return false;
}
Expand Down
Loading