Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@abrush21
Copy link
Contributor

This PR fixes an issue with the hit test algorithm whereby it would prematurely stop searching for nodes that enclose the hit point. If a child that encloses the touch point is not focusable, the algorithm should move on to the next child.

fxb/68331

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jan 25, 2021
@abrush21 abrush21 changed the title Ensures that hit testing only resturns focusable nodes. Ensures that hit testing only returns focusable nodes. Jan 25, 2021
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor

dnfield commented Jan 25, 2021

See also:

b/162065967
cl/353656895
b/177271344

@chinmaygarde
Copy link
Contributor

@dnfield Can we land this?

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 28, 2021
@dnfield
Copy link
Contributor

dnfield commented Jan 28, 2021

Yes - added the label

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes cp: 1.26 waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants