This repository was archived by the owner on Feb 25, 2025. It is now read-only.
move deprecation from the PluginRegistry outer interface to inner, v1-specific fields #22345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Nov 9, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2020
…nner, v1-specific fields (flutter/engine#22345)
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak #21347.
Fixes flutter/flutter#69898.
The v2 plugins APIs must have used the v1 callback listener classes for convenience originally. I've changed my initially thought approach in flutter/flutter#69898. Create a second parallel set of v2 listeners will be a colossal refactor since the listener tracking is done in many classes and would lead to error prone double tracking and a big migration. The
io.flutter.plugin.commonnamespace itself isn't deprecated and there are still general plugin functionalities like MethodChannel in that folder.I've opted to deprecate the v1 specific registry mechanisms like
registrarFor,Registraretc. But left the ActivityPluginBinding listeners. The slight disadvantage is that the listener name has a soon-to-be impertinentPluginRegistryouter class around them. But the alternative is too messy.The deprecated fields are now only accessed by v1 classes and the ShimRegistrar.