This repository was archived by the owner on Feb 25, 2025. It is now read-only.
clarify that offset is not used in addPlatformView for iOS/Android #21331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently addPlatformView's offset parameter is not used for iOS/Android. This PR clarifies that offset is not used for in addPlatformView for iOS and Android and removes offset from the scenario_app test for iOS/Android platform views.
Not yet removing offset completely since it may be used for Fuschia/Web. It may be desirable to remove offset completely for consistency between the platforms.
Also updated outdated comment stating addPlatformView is only supported for iOS.
Related Issues
flutter/flutter#37029
Tests
I added the following tests:
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.