-
Notifications
You must be signed in to change notification settings - Fork 6k
Fixed splash screen crash when bringing Android app back to foreground after being evicted from memory. (#47635) #16916
Conversation
…d after being evicted from memory. (flutter#47635)
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@tvolkert do you have any ideas for tests for this? I'm not aware of an available approach... |
|
Great, thanks for the fix Matt LGTM |
|
@xster do you know if this "Mac Web Engine" failure is real or fake? Also, any thoughts on tests for this? |
|
I'm not sure how you'd test this... |
|
@ferhatb for the web test failure - this or certainly shouldn't affect that test |
blasten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cacoon was out of sync with web directory. Issue is resolved. |
|
Ok, I'm gonna merge this without tests, and ignoring the web failure based on @ferhatb's comment. |
…oreground after being evicted from memory. (flutter#47635) (flutter/engine#16916)
…oreground after being evicted from memory. (flutter#47635) (flutter/engine#16916)
|
This correction has on the stable channel from 1.17.5 ? |
Fixed splash screen crash when bringing Android app back to foreground after being evicted from memory. (#47635)