This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update CanvasKit to 0.7.0 and flesh out painting #13240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to fix some bugs in the CanvasKit backend. - Implement RRect where the radii are different - Implement drawDRRect - Implement ColorFilter - Implement the correct `arcTo` for `arcToPoint`
yjbanov
approved these changes
Oct 19, 2019
| final js.JsArray colorMatrix = js.JsArray(); | ||
| colorMatrix.length = 20; | ||
| for (int i = 0; i < 20; i++) { | ||
| colorMatrix[i] = filter._matrix[i]; |
Contributor
There was a problem hiding this comment.
Let's leave a todo to remove this double-conversion. This should, at least, convert straight to a Float64List, but ideally we should write to WASM memory directly.
/cc @kjlubick - here's an example for excessive conversion that we talked about at the last sync.
| /// EXPERIMENTAL: Enable the Skia-based rendering backend. | ||
| const bool experimentalUseSkia = | ||
| bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: false); | ||
| bool.fromEnvironment('FLUTTER_WEB_USE_SKIA', defaultValue: true); |
Contributor
There was a problem hiding this comment.
We probably want to keep this as false.
BTW, have you checked the code size difference with and without this backend? If the size difference is small (say <50KB gzipped), I'd say let's make it a dynamic option. I imagine most of the size cost is from the WASM blob, not from Dart code.
Contributor
Author
There was a problem hiding this comment.
I'll investigate after landing this PR
ditman
reviewed
Oct 19, 2019
- Add TODO to avoid unnecessary conversions - Don't set CanvasKit to default - Fix licenses file
This was referenced Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to fix some bugs in the CanvasKit backend.
arcToforarcToPointScreenshots
Using
drawDRRectfor checkboxesShowing
ColorFilterin the "Animation" demoUsing correct
arcToto get the correct notch under the FAB