This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[dart_aot_runner] Use the host_toolchain to build kernels #13096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
commented
Oct 11, 2019
|
|
||
| deps = [ | ||
| "../kernel:kernel_platform_files($host_toolchain)", | ||
| "../kernel:kernel_platform_files", |
Contributor
Author
There was a problem hiding this comment.
@chinmaygarde , @jason-simmons maybe you guys know this, but when i specify the ($host_toolchain) here gn is unable to resolve the dependency of the input platform_dill between this and the kernel_platform_files target.
My theory is that maybe data deps can only exist between targets of same toolchain.
Contributor
Author
There was a problem hiding this comment.
I was able to look into prebuilt_dart_action and it seems to be relying on the host_toolchain by default and the redundant dependency here seems to be causing the problem. This PR should be good.
chinmaygarde
approved these changes
Oct 11, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.