Skip to content

Fix timeline processing for thread name change. #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 1 commit into from
Oct 1, 2024
Merged

Fix timeline processing for thread name change. #8383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter-candidate.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
8925e1ffdfe880b06a8bc5877f017083d6652f5b
b05246d305ac94798ca5429754917c0afa92fd9b
5 changes: 3 additions & 2 deletions ...ols_app/lib/src/screens/performance/panes/timeline_events/timeline_events_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class TimelineEventsController extends PerformanceFeatureController
static const rasterThreadSuffix = '.raster';
static const gpuThreadSuffix = '.gpu';
static const platformThreadSuffix = '.platform';
static const flutterTestThreadSuffix = '.flutter.test..platform';
static const flutterTestThreadSuffix = '.flutter.test..ui';
static final _refreshWorkTrackerDelay =
const Duration(milliseconds: 500).inMicroseconds;

Expand Down Expand Up @@ -281,7 +281,8 @@ class TimelineEventsController extends PerformanceFeatureController
// Android: "1.ui (12652)"
// iOS: "io.flutter.1.ui (12652)"
// MacOS, Linux, Windows, Dream (g3): "io.flutter.ui (225695)"
if (name.contains(uiThreadSuffix)) {
if (name.contains(uiThreadSuffix) &&
!name.contains(flutterTestThreadSuffix)) {
uiTrackId = id;
}

Expand Down