-
Notifications
You must be signed in to change notification settings - Fork 100
Switch to federated google sign in plugin #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
0801c74
switch to google sign in
4c58d8b
send body data instead of form data
8a13df8
updates
858a027
reset appengine cocoon
91a7413
sign in silently?
970cd84
sign in button separate widget
6132567
notify listener callback, auth listener
0264df2
sign out button
d8a2c4c
add todo in pubspec
3be9a9f
sign in button tests wip
237a7fe
sign in button only needs sign in service
2c03377
sentences.
6fdfc16
sign in button use auth service
f85ddef
typo
7acbb86
fix rebase merge error
bde0114
fake google sign in account, working sign in tests
a99f5f4
fix task box view log header to include id token
55445c8
fixed flutter build state test
b60179c
fixed unauthenticated sign in tests
f0fd559
fixes
f98470f
reference id token
20f88a7
build dashboard test
05b3248
fix sign out button to only signout if clicked, not when opened
8a3c957
use the git package
CaseyHillers 970ba1f
todo
34cb34c
use google sign in is signed in
095a5ed
tests updated with new signature
5b79930
add the authentication tests back
e9b0fd2
fix to future of future
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ class GoogleSignInService { | |
| final GoogleSignIn _googleSignIn; | ||
|
|
||
| /// Whether or not the application has been signed in to. | ||
| bool get isAuthenticated => user != null; | ||
| Future<bool> get isAuthenticated => _googleSignIn.isSignedIn(); | ||
|
|
||
| /// The Google Account for the signed in user, null if no user is signed in. | ||
| /// | ||
|
|
@@ -57,6 +57,5 @@ class GoogleSignInService { | |
|
|
||
| Future<void> signOut() async { | ||
| await _googleSignIn.signOut(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No action required, just want to mention that it's amusing to see "SignIn.signOut" :) |
||
| user = null; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't want to change the getter signature you may be able to do:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(You might need to change it to an async fn, so maybe you still need to change the signature after all, hmmm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.