Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Nov 7, 2019

Original PR: #513

Updates the Dart project to serve all the web assets out of it.

  • Deploy script builds the app project assets and uploads them to AppEngine
  • bin/server.dart instead of falling back to the Go code tries to serve static files

Closes flutter/flutter#43095

Demo available at http://testchillers.flutter-dashboard.appspot.com/

This is waiting on #528, #527, and #525 before landing.

Also waiting on #533 and #531

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@CaseyHillers CaseyHillers changed the title [Blocked] Reland Dart project builds app project and serves it Reland Dart project builds app project and serves it Nov 20, 2019
@CaseyHillers
Copy link
Contributor Author

I ran into this dart-lang/build#2478 when trying to do the deploy again. Running flutter packages pub upgrade fixed the issue for me.

@CaseyHillers
Copy link
Contributor Author

I have some UI clean up on the overlays I want to implement (recommendations from @digiter) before submitting this.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@CaseyHillers
Copy link
Contributor Author

I pushed an update with the latest changes at https://testchillers-dot-flutter-dashboard.appspot.com/
Old dashboard at https://testchillers-dot-flutter-dashboard.appspot.com/build-old.html

@digiter and @jonahwilliams is this okay to swap over as the main dashboard?

@jonahwilliams
Copy link
Contributor

Can we make the old dashboard available via something like old_build.html?

@CaseyHillers
Copy link
Contributor Author

Can we make the old dashboard available via something like old_build.html?

Of course! Added, redeploying now and updating the links for that.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would add a new link at https://flutter-dashboard.appspot.com/ that points to the old build dashboard.

@CaseyHillers
Copy link
Contributor Author

LGTM
I would add a new link at https://flutter-dashboard.appspot.com/ that points to the old build dashboard.

Added

@digiter
Copy link
Contributor

digiter commented Nov 20, 2019

Just a general advice, it's usually better to split this into a large change and a "launch" PR, so that the "launch" PR could be small enough to have only a few lines. Small PR is easier to review and revert.

@CaseyHillers CaseyHillers merged commit 4f31963 into flutter:master Nov 20, 2019
@CaseyHillers CaseyHillers deleted the ngdart_deploy branch November 20, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build_dashboard] Deploy app_flutter to production

3 participants