-
Notifications
You must be signed in to change notification settings - Fork 100
Reland Dart project builds app project and serves it
#523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
digiter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
ed8a103 to
f163f69
Compare
app project and serves itapp project and serves it
|
I ran into this dart-lang/build#2478 when trying to do the deploy again. Running |
|
I have some UI clean up on the overlays I want to implement (recommendations from @digiter) before submitting this. |
digiter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
bd3226a to
93e9674
Compare
|
I pushed an update with the latest changes at https://testchillers-dot-flutter-dashboard.appspot.com/ @digiter and @jonahwilliams is this okay to swap over as the main dashboard? |
|
Can we make the old dashboard available via something like old_build.html? |
Of course! Added, redeploying now and updating the links for that. |
digiter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would add a new link at https://flutter-dashboard.appspot.com/ that points to the old build dashboard.
Added |
|
Just a general advice, it's usually better to split this into a large change and a "launch" PR, so that the "launch" PR could be small enough to have only a few lines. Small PR is easier to review and revert. |
Original PR: #513
Updates the Dart project to serve all the web assets out of it.
appproject assets and uploads them to AppEnginebin/server.dartinstead of falling back to the Go code tries to serve static filesCloses flutter/flutter#43095
Demo available at http://testchillers.flutter-dashboard.appspot.com/
This is waiting on #528, #527, and #525 before landing.Also waiting on #533 and #531