Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

url_launcher will resolve to a version that does not work on web. This is a temporary fix as I presume this is just from the work being done for federated plugins.

See flutter/flutter#44012 (comment) for more information.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers merged commit 254ec5f into flutter:master Nov 7, 2019
@CaseyHillers CaseyHillers deleted the url_fix branch November 7, 2019 00:05
CaseyHillers added a commit to CaseyHillers/cocoon that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants