Fix .ci.yaml validation for Fusion (the monorepo)
#4137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Dec 26, 2024
| exceptions.add('ERROR: ${target.name} is missing `.ci.yaml` in runIf'); | ||
| } | ||
|
|
||
| // 2. The engine repo must additionally depend on DEPS. |
Contributor
There was a problem hiding this comment.
Can you please leave a TODO with a link to an issue reminding us to clean this up once we're ready to archive the engine repo?
| final ciYamlPath = switch (type) { | ||
| CiType.fusionEngine => 'engine/src/flutter/.ci.yaml', | ||
| _ => '.ci.yaml', | ||
| }; |
Contributor
There was a problem hiding this comment.
Can these be added automatically by the .ci.yaml parser (or by the logic that evaluates runIf conditions)? This way we don't have to specify anything in the yaml files. Seems like they add a bunch of noise. Totally fine we want to take this one step at a time though.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/cocoon/4137, due to - The status or check suite Linux Cocoon has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 27, 2024
Few entries were missed in #160706 and caused [failures](https://github.com/flutter/flutter/pull/160191/checks?check_run_id=34920131317) when [this](flutter/cocoon#4137) landed.
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 27, 2024
Few entries were missed in #160706 and caused [failures](https://github.com/flutter/flutter/pull/160191/checks?check_run_id=34920131317) when [this](flutter/cocoon#4137) landed.
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 7, 2025
Towards #160915 (future cleanup: remove the validation from `flutter/cocoon`). This PR effectively duplicates the logic in flutter/cocoon#4137, in `flutter/flutter`. /cc @jtmcdole
srujzs
pushed a commit
to srujzs/flutter
that referenced
this pull request
Jan 12, 2025
…61249) Towards flutter#160915 (future cleanup: remove the validation from `flutter/cocoon`). This PR effectively duplicates the logic in flutter/cocoon#4137, in `flutter/flutter`. /cc @jtmcdole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#160707.
Fixes a bug where
DEPSwas accidentally (or purposefully, there were no tests to verify) not checked for framework builds, and then expands on the validation by adding a check forengine/**for framework builds, adding a check nobody usesrunIfNot, which is extremely broken and should not be used, and then lastly refactors the code and adds tests for the next shmuck to want to change this.