Skip to content

Make Impeller test harnesses + fixtures test exempt in the engine repo. #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 8, 2023
Merged

Make Impeller test harnesses + fixtures test exempt in the engine repo. #3240

auto-submit merged 1 commit into from
Nov 8, 2023

Conversation

@bdero
Copy link
Member

@bdero bdero commented Nov 8, 2023 •
edited
Loading

  • impeller/fixtures contains only test fixtures.
  • impeller/golden_tests contains a test harness for goldens.
  • impeller/playground contains a test harness that spawns Impeller backends. Also used for capturing goldens.

Patch where this was noticed: flutter/engine#47781

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bdero bdero requested a review from jason-simmons November 8, 2023 03:50
@bdero bdero requested a review from keyonghan as a code owner November 8, 2023 03:50
jonahwilliams
jonahwilliams approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero mentioned this pull request Nov 8, 2023
Merged
keyonghan
keyonghan approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 8, 2023
@auto-submit auto-submit bot merged commit 2b4916b into flutter:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdero @jonahwilliams @keyonghan