Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Add deprecation warnings when compiling Android engine #548

Merged
camsim99 merged 2 commits into from
Feb 18, 2022
Merged

Add deprecation warnings when compiling Android engine #548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22ef845
Add deprecation warnings for Android engine
camsim99 Feb 14, 2022
dde7861
Add issue reference
camsim99 Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions build/android/gyp/javac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,12 @@ def DoJavac(
# javac pulling a default encoding from the user's environment.
'-encoding', 'UTF-8',
'-classpath', ':'.join(classpath),
'-d', classes_dir]
'-d', classes_dir,
# TODO(camsim99): Make deprecation warnings fatal and remove limit
Copy link
Member

@chinmaygarde chinmaygarde Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be filed as as bug and the number cross-referenced here.

# when all 123 (at the time of this comment) deprecations are fixed:
# https://github.com/flutter/flutter/issues/98602.
'-Xlint:deprecation',
'-Xmaxwarns', '123']

if bootclasspath:
javac_args.extend([
Expand All @@ -88,7 +93,6 @@ def DoJavac(
])

if chromium_code:
# TODO(aurimas): re-enable '-Xlint:deprecation' checks once they are fixed.
javac_args.extend(['-Xlint:unchecked'])
else:
# XDignore.symbol.file makes javac compile against rt.jar instead of
Expand Down