This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Update default builds to use the C++ 17 standard. #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ Standard version selection has been moved into it's own config. This allows leaf targets to yank the config from the native compiler configs and specifying their own opinion. This is better than adding cflags directly because the those will be added after the default specification. Such invocations fail on some platforms (Windows) and cause confusion on others where two standards are defined. The targets that are not yet ready for C++17 now have their versions pinned.
jason-simmons
approved these changes
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ Standard version selection has been moved into it's own config. This allows
leaf targets to yank the config from the native compiler configs and specifying
their own opinion. This is better than adding cflags directly because the those
will be added after the default specification. Such invocations fail on some
platforms (Windows) and cause confusion on others where two standards are
defined.
The targets that are not yet ready for C++17 now have their versions pinned.