Skip to content

[webview_flutter] Apply PlatformView's Intreface #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbrto21 merged 4 commits into from
Jul 19, 2021
Merged

[webview_flutter] Apply PlatformView's Intreface #146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5b01b2
[webview_flutter] Apply PlatformView's Intreface
bwikbs Jul 9, 2021
c125616
Apply's review's comment
bwikbs Jul 14, 2021
f62d3f1
Refactor helper function for EncodableMap value
bwikbs Jul 15, 2021
c8614f0
Apply PlatformView's Intreface #2
bwikbs Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/webview_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,7 @@
## 0.2.2
* Update lightweight web engine binary & header file (6263be6c888d5cb9dcca5466dfc3941a70b424eb)
* Activate resizing function
* Apply embedder's texture APIs change
* Apply embedder's texture APIs change

## 0.3.0
* Apply PlatformView, PlatformViewFactory APIs change
2 changes: 1 addition & 1 deletion packages/webview_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: webview_flutter_tizen
description: Tizen implementation of the webview plugin
homepage: https://github.com/flutter-tizen/plugins
version: 0.2.2
version: 0.3.0

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down
4 changes: 2 additions & 2 deletions packages/webview_flutter/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,8 @@ double ExtractDoubleFromMap(const flutter::EncodableValue& arguments,

WebView::WebView(flutter::PluginRegistrar* registrar, int viewId,
flutter::TextureRegistrar* texture_registrar, double width,
double height, flutter::EncodableMap& params)
: PlatformView(registrar, viewId),
double height, flutter::EncodableMap& params, void* winHandle)
: PlatformView(registrar, viewId, winHandle),
texture_registrar_(texture_registrar),
webview_instance_(nullptr),
width_(width),
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/tizen/src/webview.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class WebView : public PlatformView {
public:
WebView(flutter::PluginRegistrar* registrar, int viewId,
flutter::TextureRegistrar* textureRegistrar, double width,
double height, flutter::EncodableMap& params);
double height, flutter::EncodableMap& params, void* winHandle);
~WebView();
virtual void Dispose() override;
virtual void Resize(double width, double height) override;
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter/tizen/src/webview_factory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ PlatformView* WebViewFactory::Create(int viewId, double width, double height,

try {
return new WebView(GetPluginRegistrar(), viewId, texture_registrar_, width,
height, params);
height, params, platform_window_);
} catch (const std::invalid_argument& ex) {
LOG_ERROR("[Exception] %s\n", ex.what());
return nullptr;
Expand Down