Skip to content

Conversation

@swift-kim
Copy link
Member

Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bbrto21 bbrto21 added the no merge This PR is not ready for merge yet label Aug 3, 2021
@swift-kim swift-kim force-pushed the accessor branch 2 times, most recently from 5de5ada to 2b047e2 Compare August 3, 2021 05:42
@swift-kim swift-kim removed the no merge This PR is not ready for merge yet label Aug 4, 2021
@swift-kim swift-kim merged commit c174826 into flutter-tizen:flutter-2.2.1-tizen Aug 5, 2021
swift-kim added a commit that referenced this pull request Sep 27, 2021
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Nov 14, 2021
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Dec 9, 2021
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Dec 17, 2021
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Feb 7, 2022
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Feb 11, 2022
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request May 12, 2022
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim added a commit that referenced this pull request Aug 5, 2022
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
Earlier, no PerVertexData struct would be generated. The shader is
useless without reflection information.

Fixes flutter/flutter#102521.
swift-kim added a commit that referenced this pull request Sep 1, 2022
* Make public members of FlutterTizenEngine class private

* Organize includes and clean up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants