msi: fix bug where install fails for path with spaces

[daipom]

• Fixes fluent-package-6.0.0-x64.msi cannot be installed to folder with spaces on Windows #926

[daipom]

Checking CI fails without the fix.
I will add the fix later.

[daipom]

Reproduced.

https://github.com/fluent/fluent-package-builder/actions/runs/18339481012/job/52231384559?pr=927

[daipom]

We need to fix Rocky Linux 8 and Amazon Linux 2023 tests...

[daipom]

Windows tests passed.

[Watson1978]

When I tried this change on my local machine, it shows following intall log with msiexec /i fluent-package-6.0.0-x64.msi /quiet /L*v install.log OPTLOCATION="C:\opt with space" command.

I don't know whether it has a problem....
Dou you know about it?

MSI (s) (DC:B0) [10:12:12:939]: Executing op: ActionStart(Name=CreateCompatTdAgentBat,,)
MSI (s) (DC:B0) [10:12:12:943]: Executing op: CustomActionSchedule(Action=CreateCompatTdAgentBat,ActionType=3073,Source=BinaryData,Target=WixQuietExec64,CustomActionData="cmd" /c "fsutil hardlink create ^"C:\opt with space\fluent\bin\td-agent.bat^" ^"C:\opt with space\fluent\fluentd.bat^"")
MSI (s) (DC:10) [10:12:12:948]: Invoking remote custom action. DLL: C:\WINDOWS\Installer\MSIA3EE.tmp, Entrypoint: WixQuietExec64
MSI (s) (DC:B0) [10:12:13:018]: Executing op: ActionStart(Name=CreateCompatTdAgentGemBat,,)
WixQuietExec64:  C:\opt with space\fluent\bin\td-agent.bat <<===>> C:\opt with space\fluent\fluentd.bat のハード リンクが作成されました
MSI (s) (DC:B0) [10:12:13:018]: Executing op: CustomActionSchedule(Action=CreateCompatTdAgentGemBat,ActionType=3073,Source=BinaryData,Target=WixQuietExec64,CustomActionData="cmd" /c "fsutil hardlink create ^"C:\opt with space\fluent\bin\td-agent-gem.bat^" ^"C:\opt with space\fluent\fluent-gem.bat^"")
MSI (s) (DC:34) [10:12:13:024]: Invoking remote custom action. DLL: C:\WINDOWS\Installer\MSIA42D.tmp, Entrypoint: WixQuietExec64
MSI (s) (DC:B0) [10:12:13:081]: Executing op: ActionStart(Name=PostNotifyWithToastBat,,)
WixQuietExec64:  C:\opt with space\fluent\bin\td-agent-gem.bat <<===>> C:\opt with space\fluent\fluent-gem.bat のハード リンクが作成されました
MSI (s) (DC:B0) [10:12:13:082]: Executing op: CustomActionSchedule(Action=PostNotifyWithToastBat,ActionType=1025,Source=BinaryData,Target=WixQuietExec64,CustomActionData="C:\opt with space\fluent\bin\fluent-package-post-toast.bat")
MSI (s) (DC:C8) [10:12:13:087]: Invoking remote custom action. DLL: C:\WINDOWS\Installer\MSIA47C.tmp, Entrypoint: WixQuietExec64
MSI (s) (DC:08) [10:12:13:089]: Generating random cookie.
MSI (s) (DC:08) [10:12:13:096]: Created Custom Action Server with PID 6244 (0x1864).
MSI (s) (DC:DC) [10:12:13:117]: Running as a service.
MSI (s) (DC:DC) [10:12:13:119]: Hello, I'm your 32bit Impersonated custom action server.
WixQuietExec64:  "1" 個の引数を指定して "CreateToastNotifier" を呼び出し中に例外が発生しました: "パラメーターが間違っています。
WixQuietExec64:  applicationId"
WixQuietExec64:  発生場所 C:\opt with space\fluent\bin\fluent-package-post-toast.ps1:23 文字:1
WixQuietExec64:  + [Windows.UI.Notifications.ToastNotificationManager, Windows.UI.Notifi ...
WixQuietExec64:  + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
WixQuietExec64:      + CategoryInfo          : NotSpecified: (:) , MethodInvocationException
WixQuietExec64:      + FullyQualifiedErrorId : ArgumentException
MSI (s) (DC:B0) [10:12:14:385]: Executing op: End(Checksum=0,ProgressTotalHDWord=0,ProgressTotalLDWord=387873336)
WixQuietExec64:   
MSI (s) (DC:B0) [10:12:14:658]: Note: 1: 2265 2:  3: -2147287035 
MSI (s) (DC:B0) [10:12:14:660]: User policy value 'DisableRollback' is 0
MSI (s) (DC:B0) [10:12:14:660]: Machine policy value 'DisableRollback' is 0
MSI (s) (DC:B0) [10:12:14:664]: Note: 1: 2265 2:  3: -2147287035 
MSI (s) (DC:B0) [10:12:14:844]: Note: 1: 2318 2:  
MSI (s) (DC:B0) [10:12:14:848]: Note: 1: 2318 2:  
MSI (s) (DC:B0) [10:12:14:851]: No System Restore sequence number for this installation.
MSI (s) (DC:B0) [10:12:14:851]: Unlocking Server
MSI (s) (DC:B0) [10:12:14:854]: PROPERTY CHANGE: Deleting UpdateStarted property. Its current value is '1'.
Action ended 10:12:14: InstallFinalize. Return value 1.
Action ended 10:12:14: INSTALL. Return value 1.

[daipom]

Oh... Thanks for the test.
Did the installation fail?

[Watson1978]

The installation of Fluent Package was successful.

[daipom]

I see.
Hmm, is that error related to this PR?

[daipom]

I see. Hmm, is that error related to this PR?

I have confirmed that the error occurs in the standard installation of v6.0.0, so it seems to be another issue.

[Watson1978]

I have confirmed that the error occurs in the standard installation of v6.0.0, so it seems to be another issue.

I see. thanks.

[Watson1978]

👍🏻

[kenhys]

LGTM.