Fix: Gymnasium compliance and corner points detection bug#38
Fix: Gymnasium compliance and corner points detection bug#38faustoallegrini wants to merge 3 commits intofloriankagerer:mainfrom
Conversation
- Explicitly handle `seed` in `reset(seed=...)` to ensure reproducible initialization - Pass custom attributes via `options` in `reset(..., options=...)` instead of positional/extra args - Return `truncated` flag from `step(...)` alongside `(obs, reward, terminated, truncated, info)` Reason: Align environment behavior with Gymnasium API expectations: - Deterministic seeding through the `seed` parameter - Proper use of the `options` dict for extra reset configuration - Complete step signature including the `truncated` signal Refs: Gymnasium env API: reset(seed=None, options=None); step(...) must return truncated.
- Fixed logic error that caused incomplete detection of corner points - Ensured all valid corners are now properly identified Reason: Previous implementation missed some corners due to incorrect detection logic.
|
Hello faustoallegrini, I'm afraid that I need more time to carefully review your changes.
Thanks again for your contribution. Best regards, |
|
Hello Florian, Best regards, |
This PR introduces two key fixes to improve compliance and correctness:
Gymnasium API compliance
seedparameter inreset(seed=...)for reproducible initializationoptionsinreset(..., options=...)instead of positional argumentsstep(...)returns thetruncatedflag along with(obs, reward, terminated, truncated, info)Corner points detection bug